Re: [PATCH] staging: greybus: audio_manager_module: make envp array static const
cjz_VM <[email protected]> Thu, 13 Nov 2025 21:39:54 +0800
| Newsgroups | dev.linux.lists.outreachy,dev.linux.lists.linux-staging,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Hi Greg, Thanks for reviewing my patch! For sending twice: I apologize for the duplicate. After the first send, I realized I had missed some greybus-specific maintainers, so I resent to include them all. For the indentation: You're right to ask about it. When I changed the declaration from 'char *envp[]' to 'static const char * const envp[]', the opening bracket moved to the right due to the longer declaration. I added tabs to keep the array elements aligned with the opening bracket, following the kernel coding style rule that parameters should align with the opening parenthesis. If this alignment approach is not preferred, I'm happy to adjust it to whatever style you recommend. Thanks again for your time and guidance! Best regards, Chang JunzhengFrom: cjz_VM <[email protected]> To: Greg Kroah-Hartman <[email protected]> Cc: [email protected], Vaibhav Agarwal <[email protected]>, Mark Greer <[email protected]>, Johan Hovold <[email protected]>, Alex Elder <[email protected]>, [email protected], [email protected], [email protected], [email protected] Subject: Re: [PATCH] staging: greybus: audio_manager_module: make envp array static const Reply-To: In-Reply-To: <2025111341-attendee-ferment-262b@gregkh> Hi Greg, Thanks for reviewing my patch! For sending twice: I apologize for the duplicate. After the first send, I realized I had missed some greybus-specific maintainers, so I resent to include them all. For the indentation: You're right to ask about it. When I changed the declaration from 'char *envp[]' to 'static const char * const envp[]', the opening bracket moved to the right due to the longer declaration. I added tabs to keep the array elements aligned with the opening bracket, following the kernel coding style rule that parameters should align with the opening parenthesis. If this alignment approach is not preferred, I'm happy to adjust it to whatever style you recommend. Thanks again for your time and guidance! Best regards, Chang Junzheng