Re: [PATCH] staging: sm750fb: make g_fbmode array const
Ahmet Sezgin Duran <[email protected]> Tue, 9 Jun 2026 09:12:29 +0300
| Newsgroups | dev.linux.lists.outreachy,dev.linux.lists.linux-staging,org.kernel.vger.linux-fbdev,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On 6/9/26 4:17 AM, Brock Haftner wrote: > The g_fbmode array is a static array of constant strings, but the pointer > array itself is not marked as const. Fix the checkpatch.pl warning by > adding the const modifier to the array declaration. > > Signed-off-by: Brock Haftner <[email protected]> > --- > drivers/staging/sm750fb/sm750.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c > index 89c811e0806c..8f533f3b1b42 100644 > --- a/drivers/staging/sm750fb/sm750.c > +++ b/drivers/staging/sm750fb/sm750.c > @@ -21,7 +21,7 @@ > static int g_hwcursor = 1; > static int g_noaccel __ro_after_init; > static int g_nomtrr __ro_after_init; > -static const char *g_fbmode[] = {NULL, NULL}; > +static const char * const g_fbmode[] = {NULL, NULL}; > static const char *g_def_fbmode = "1024x768-32@60"; > static char *g_settings; > static int g_dualview __ro_after_init; Did you compile this patch while enabling sm750fb driver in the config? Regards, Ahmet Sezgin Duran