Re: [PATCH 7.1 667/744] ptp: ptp_s390: Add missing facility check

On 30. 07. 26, 16:15, Greg Kroah-Hartman wrote:
> 7.1-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Sven Schnelle <[email protected]>
> 
> commit e78f1ac37afcb16cb6fef8a2c92591eab6558956 upstream.
> 
> Only register the physical clock when facility 28 is installed
> and PTFF QAF returns that PTFF QPT is available.
> 
> Fixes: 2d7de7a3010d ("s390/time: Add PtP driver")
> Signed-off-by: Sven Schnelle <[email protected]>
> Cc: [email protected]
> Reviewed-by: Heiko Carstens <[email protected]>
> Link: https://patch.msgid.link/[email protected]
> Signed-off-by: Jakub Kicinski <[email protected]>
> Signed-off-by: Greg Kroah-Hartman <[email protected]>
> ---
>   drivers/ptp/ptp_s390.c |    6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
> 
> --- a/drivers/ptp/ptp_s390.c
> +++ b/drivers/ptp/ptp_s390.c
> @@ -107,6 +107,9 @@ static __init int ptp_s390_init(void)
>   	if (IS_ERR(ptp_stcke_clock))
>   		return PTR_ERR(ptp_stcke_clock);
>   
> +	if (!test_facility(28) || !ptff_query(PTFF_QPT))

ptff_query() here needs:
9de445d8296a ("s390/ptff: Export ptff_function_mask[]")

thanks,
-- 
js
suse labs