Re: [PATCH 6.12 469/602] i2c: davinci: Unregister cpufreq notifier on probe failure

Sasha Levin <[email protected]> Fri, 31 Jul 2026 22:39:07 -0400
Newsgroups dev.linux.lists.patches,org.kernel.vger.stable
Message-ID <[email protected]>
On Fri, Jul 31, 2026 at 10:40:53PM +0530, Harshit Mogalapalli wrote:
>I think this backport is incomplete; I think route both GPIO failure
>branches through err_cpufreq:

Both IS_ERR() checks are inside "else if (dev->pdata->gpio_recovery)",
and nothing sets gpio_recovery in either tree - dead code.

They also used "goto err_unuse_clocks" before this patch, so it's a
pre-existing gap, not a regression. The patch fixes the
i2c_add_numbered_adapter() leak; dropping it is strictly worse.

And since b04ce6385979 deleted the block in v6.14, there's no upstream
commit to backport for the rest.

Thanks for the review.

-- 
Thanks,
Sasha