Re: [PATCH 6.12 513/602] sunrpc: allocate a separate bvec array for socket sends

On Sat, Aug 01, 2026 at 09:57:48AM +0530, Harshit Mogalapalli wrote:
>The 6.12.y backport instead allocates sk_bvec unconditionally in
>svc_setup_socket() with kcalloc(RPCSVC_MAXPAGES + 1, ...), including
>for permanent TCP listener sockets.
>
>I do not see a correctness issue here. So I think this looks like an
>acceptable 6.12.y adaptation, even though it does not preserve the exact
>upstream allocation policy.

I think I agree with you, and the divergence is intentional. 6.12 and 6.6
have neither svc_sock_sendpages() nor svc_serv_maxpages().

>I don't think there is anything to fix, but would like to double check,
>thoughts ?

Nothing to fix, the patch stays. It's also a hard prerequisite for
18c1cc698861 ("SUNRPC: Return an error from xdr_buf_to_bvec() on
overflow"), which is queued immediately after it in all three series and
patches the exact svsk->sk_bvec call sites this one introduces.

Thanks for the careful review.

-- 
Thanks,
Sasha