Re: [PATCH 6.12 129/337] pinctrl: microchip-sgpio: add missing select REGMAP_MMIO

Hi Greg,

On 07/08/26 8:05 pm, Greg Kroah-Hartman wrote:
> 6.12-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Benjamin Boortz <[email protected]>
> 
> commit 25cb6e9a13123d1039cdc75b446ac52e1ebdc26d upstream.
> 
> The driver calls ocelot_regmap_from_resource() via <linux/mfd/ocelot.h>,
> which internally uses devm_regmap_init_mmio() and requires REGMAP_MMIO.
> The Kconfig entry does not select REGMAP_MMIO, causing a build failure
> when no other driver in the config happens to pull in REGMAP_MMIO:
> 
>    include/linux/mfd/ocelot.h:34:24: error: implicit declaration of function 'devm_regmap_init_mmio'
> 
> Found by randconfig testing on arm64; tinyconfig reproducer below.
> 
> Fixes: 2afbbab45c26 ("pinctrl: microchip-sgpio: update to support regmap")
> Cc: [email protected]
> Signed-off-by: Benjamin Boortz <[email protected]>
> Reviewed-by: Andy Shevchenko <[email protected]>
> Signed-off-by: Linus Walleij <[email protected]>
> Signed-off-by: Greg Kroah-Hartman <[email protected]>
> ---
>   drivers/pinctrl/Kconfig |    1 +
>   1 file changed, 1 insertion(+)
> 
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -213,6 +213,7 @@ config PINCTRL_EQUILIBRIUM
>   	select GENERIC_PINCONF
>   	select GENERIC_PINCTRL_GROUPS
>   	select GENERIC_PINMUX_FUNCTIONS
> +	select REGMAP_MMIO

I have run an AI assisted backport review and it spotted an issue; I 
checked the Kconfig delta and the selector was added to the wrong symbol.

Upstream has:
config PINCTRL_MICROCHIP_SGPIO
	...
	select REGMAP_MMIO


The posted 6.12.y change instead leaves PINCTRL_MICROCHIP_SGPIO without 
that line and adds it under PINCTRL_EQUILIBRIUM.

I suggest moving select REGMAP_MMIO to the PINCTRL_MICROCHIP_SGPIO.


Thanks,
Harshit
>   	help
>   	  Equilibrium driver is a pinctrl and GPIO driver for Intel Lightning
>   	  Mountain network processor SoC that supports both the GPIO and pin
> 
> 
>