Re: [PATCH 6.12 0139/1276] arm64: dts: qcom: sc7180: Add power-domain and iface clk for ice node

Hi all,

On 02-08-2026 11:40 am, Harshal Dev wrote:
> Hi Sasha, Harshit
> 
> On 01-08-2026 07:50 pm, Sasha Levin wrote:
>> On Fri, Jul 31, 2026 at 12:51:25PM +0530, Harshal Dev wrote:
>>> The 1st can be taken on-top of the four DTS, since describing the clocks
>>> first but enabling them later via the commit is totally fine.
>>
>> Thanks for confirming - and no worries about the delay, enjoy the
>> vacation.
>>
>> 0d5dc5818191 ("soc: qcom: ice: Allow explicit votes on 'iface' clock for ICE")
>> stays queued for 6.12 on that basis. It closes the gap the four DTS commits
>> already shipped in v6.12.97 opened up, and I confirmed it's harmless on the
>> 6.12 nodes that were never converted (sm8550, sa8775p):
>> devm_clk_get_optional_enabled(dev, "iface") just resolves to NULL there, same
>> as mainline.
>>
>>> The 2nd one should be taken to make the DTS patches comply with an updated
>>> binding. [...] However, the patch must be adapted to 6.12 to not make the
>>> power-domain and clock-names mandatory for Eliza and Milos since those
>>> targets arrived in 7.1 kernel. Only the first portion of the patch is
>>> applicable for 6.12.
>>
>> Agreed, and that matches what I see: the allOf/if-then block in e27264daac7d
>> keys on qcom,eliza-inline-crypto-engine and qcom,milos-inline-crypto-engine,
>> and neither compatible exists in the 6.12 binding's enum, so it can't go in
>> verbatim.
>>
>> We don't hand-split upstream commits in the stable queue, though, so
>> could you send the adapted version yourself once you're back? Please
>> post it to [email protected] targeting both 6.12 and 6.18 - 6.18
>> shipped the driver change already and has the same binding gap.
> 
> Sure, I will send an adapted version after validating the binding with it.
> I will be back in office next week and will be able to provide the patch.
>

As promised, adapted patches have been sent to [email protected]:
https://lore.kernel.org/stable/20260812-adapt-ice-binding-for-6-12-v1-1-ba4374b81a3e@oss.qualcomm.com/
https://lore.kernel.org/stable/20260812-adapt-ice-binding-for-6-18-v1-1-e224dcf77072@oss.qualcomm.com/

Regards,
Harshal 
> Regards,
> Harshal
> 
>>
>> Thanks!
>>
>