Re: [PATCH 6.12 289/337] mm/slab: prevent unbounded recursion in free path with new kmalloc type
Harry Yoo <[email protected]>
| Newsgroups | dev.linux.lists.patches,org.kernel.vger.stable |
|---|---|
| Message-ID | <aoGCsmkycnDCNNfZ@ubuntu-vm-arm64> |
On Sat, Aug 08, 2026 at 07:10:33AM -0400, Sasha Levin wrote: > On Fri, Aug 07, 2026 at 11:02:45AM -0700, Nathan Chancellor wrote: > > linux/mm/slab.h:572:24: error: duplicate 'inline' declaration specifier [-Werror,-Wduplicate-decl-specifier] > > 572 | static __always_inline inline bool need_kmalloc_no_objext(void) > > > > The 'inline' should be dropped, as '__always_inline' includes 'inline' > > already. Ouch, thanks for catching. It's silly that I didn't catch it while testing. > Fixed in the queue - I dropped the redundant 'inline' and kept > '__always_inline', so the 6.12 backport now reads: > > static __always_inline bool need_kmalloc_no_objext(void) Looks good to me, thanks for fixing!