[Powertop] [PATCH 2/3] fix-warnings: Ignoring return value

Alexandra Yates <alexandra.yates at linux.intel.com>
Newsgroups dev.linux.lists.powertop
Message-ID <1402697910-29154-3-git-send-email-alexandra.yates@linux.intel.com>
Added error handling to system() and write() calls.

Signed-off-by: Alexandra Yates <alexandra.yates(a)linux.intel.com>
---
 src/calibrate/calibrate.cpp |   16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/src/calibrate/calibrate.cpp b/src/calibrate/calibrate.cpp
index db368e0..a9a0a7c 100644
--- a/src/calibrate/calibrate.cpp
+++ b/src/calibrate/calibrate.cpp
@@ -33,6 +33,7 @@
 #include <pthread.h>
 #include <math.h>
 #include <sys/types.h>
+#include <errno.h>
 
 #include "../parameters/parameters.h"
 extern "C" {
@@ -239,7 +240,8 @@ static void *burn_disk(void *dummy)
 
 	while (!stop_measurement) {
 		lseek(fd, 0, SEEK_SET);
-		write(fd, buffer, 64*1024);
+		if(write(fd, buffer, 64*1024) == -1)
+			printf("Error: %s\n", strerror(errno));
 		fdatasync(fd);
 	}
 	close(fd);
@@ -350,17 +352,21 @@ static void backlight_calibration(void)
 		sleep(1);
 	}
 	printf(_("Calibrating idle\n"));
-	system("DISPLAY=:0 /usr/bin/xset dpms force off");
+	if(!system("DISPLAY=:0 /usr/bin/xset dpms force off"))
+		printf("System is not available\n");
 	one_measurement(15, NULL);
-	system("DISPLAY=:0 /usr/bin/xset dpms force on");
+	if(!system("DISPLAY=:0 /usr/bin/xset dpms force on"))
+		printf("System is not available\n");
 }
 
 static void idle_calibration(void)
 {
 	printf(_("Calibrating idle\n"));
-	system("DISPLAY=:0 /usr/bin/xset dpms force off");
+	if(!system("DISPLAY=:0 /usr/bin/xset dpms force off"))
+		printf("System is not available\n");
 	one_measurement(15, NULL);
-	system("DISPLAY=:0 /usr/bin/xset dpms force on");
+	if(!system("DISPLAY=:0 /usr/bin/xset dpms force on"))
+		printf("System is not available\n");
 }
 
 
-- 
1.7.9.5
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.