Re: [Powertop] [PATCH v3] conditionally disable pci if not supported
Rajagopal Venkat <rajagopal.venkat at linaro.org>
| Newsgroups | dev.linux.lists.powertop |
|---|---|
| Message-ID | <CA+Z25wX+sL99ZQhEFeysO6THfEh+7ciC_zhwTDw=C4W2ZrT8+Q@mail.gmail.com> |
On 13 July 2012 11:03, Ricardo Salveti <ricardo.salveti(a)linaro.org> wrote: > On Fri, Jul 13, 2012 at 2:02 AM, Rajagopal Venkat > <rajagopal.venkat(a)linaro.org> wrote: > > Can someone consider this patch for merge? > > As we will have libpci available at most distros by default, isn't > there a way of doing run-time detection instead of disabling it at > build time? > This patch disables powertop PCI support only when libpci is not available on a system. Nothing specific to ARM platforms. I don't think it can be done at run-time. Without this patch if libpci is not available, powertop compilation itself will fail. > This is just because we'll be getting more and more ARM boards which > have PCI-e as well, so we'll need to handle systems with and without > any PCI available. > > Cheers, > -- > Ricardo Salveti de Araujo >
attachment.html
(text/html, 1.5 KB)
<br><br><div class="gmail_quote">On 13 July 2012 11:03, Ricardo Salveti <span dir="ltr"><<a href="mailto:[email protected]" target="_blank">[email protected]</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div class="im">On Fri, Jul 13, 2012 at 2:02 AM, Rajagopal Venkat<br> <<a href="mailto:[email protected]">[email protected]</a>> wrote:<br> > Can someone consider this patch for merge?<br> <br> </div>As we will have libpci available at most distros by default, isn't<br> there a way of doing run-time detection instead of disabling it at<br> build time?<br> </blockquote><div>This patch disables powertop PCI support only when libpci is not <br>available on a system. Nothing specific to ARM platforms. <br><br>I don't think it can be done at run-time. Without this patch if libpci<br> is not available, powertop compilation itself will fail. <br> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> This is just because we'll be getting more and more ARM boards which<br> have PCI-e as well, so we'll need to handle systems with and without<br> any PCI available.<br> <br></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> Cheers,<br> <span class="HOEnZb"><font color="#888888">--<br> Ricardo Salveti de Araujo<br> </font></span></blockquote></div><br>