Re: [Powertop] segfault on Sheevaplug (ARM Kirkwood)
Rui DaCosta <ruidc at yahoo.com>
| Newsgroups | dev.linux.lists.powertop |
|---|---|
| Message-ID | <[email protected]> |
Thanks,
this has gotten past the issue. I now get:
PowerTOP v2.0 needs the kernel to support the 'perf' subsystem
as well as support for trace points in the kernel:
CONFIG_PERF_EVENTS=y
CONFIG_PERF_COUNTERS=y
CONFIG_TRACEPOINTS=y
CONFIG_TRACING=y
all these except CONFIG_PERF_COUNTERS are already set, so i'll need to see if i can get a kernel built with that option on.
Will this patch make it into trunk?
Many thanks.
________________________________
From: Sergey Senozhatsky <sergey.senozhatsky(a)gmail.com>
To: Rui DaCosta <ruidc(a)yahoo.com>
Cc: Arjan van de Ven <arjan(a)linux.intel.com>; Chris Ferron <chris.e.ferron(a)linux.intel.com>; powertop(a)lists.01.org
Sent: Sunday, 20 May 2012, 11:34
Subject: Re: [Powertop] segfault on Sheevaplug (ARM Kirkwood)
On (05/20/12 02:19), Rui DaCosta wrote:
> Sure and thanks,
> (v1.13 worked fine btw)
> Processor : Feroceon 88FR131 rev 1 (v5l)
> BogoMIPS : 1191.11
> Features : swp half thumb fastmult edsp
> CPU implementer : 0x56
> CPU architecture: 5TE
> CPU variant : 0x2
> CPU part : 0x131
> CPU revision : 1
>
> Hardware : Marvell SheevaPlug Reference Board
> Revision : 0000
> Serial : 0000000000000000
>
>
Thanks,
Well, that's the problem. Current cpu info parser doesn't understand your
cpuinfo format. It awaits for sane values on special places. For example, word
"processor" should be followed by a number, not model name.
processor : 2
vendor_id : GenuineIntel
cpu family : 6
model : 37
bogomips : 4522.66
while cpuinfo on your system is totally different.
the following is untested patch (I'm a bit skeptical) plus I don't have
ARM device for testing.
---
src/cpu/cpu.cpp | 26 ++++++++++++++------------
1 file changed, 14 insertions(+), 12 deletions(-)
diff --git a/src/cpu/cpu.cpp b/src/cpu/cpu.cpp
index 09d4a2d..143e18c 100644
--- a/src/cpu/cpu.cpp
+++ b/src/cpu/cpu.cpp
@@ -225,7 +225,7 @@ void enumerate_cpus(void)
ifstream file;
char line[1024];
- int number = -1;
+ int number = 1;
char vendor[128];
int family = 0;
int model = 0;
@@ -236,7 +236,6 @@ void enumerate_cpus(void)
return;
while (file) {
-
file.getline(line, sizeof(line));
if (strncmp(line, "vendor_id\t",10) == 0) {
char *c;
@@ -247,42 +246,45 @@ void enumerate_cpus(void)
c++;
strncpy(vendor,c, 127);
}
- }
- if (strncmp(line, "processor\t",10) == 0) {
+ } else if (strncmp(line, "processor\t",10) == 0) {
char *c;
c = strchr(line, ':');
if (c) {
c++;
number = strtoull(c, NULL, 10);
}
- }
- if (strncmp(line, "cpu family\t",11) == 0) {
+ } else if (strncmp(line, "Processor\t",10) == 0) {
+ char *c;
+ c = strchr(line, ':');
+ if (c) {
+ c++;
+ if (*c == ' ')
+ c++;
+ strncpy(vendor, c, 127);
+ }
+ } else if (strncmp(line, "cpu family\t",11) == 0) {
char *c;
c = strchr(line, ':');
if (c) {
c++;
family = strtoull(c, NULL, 10);
}
- }
- if (strncmp(line, "model\t",6) == 0) {
+ } else if (strncmp(line, "model\t",6) == 0) {
char *c;
c = strchr(line, ':');
if (c) {
c++;
model = strtoull(c, NULL, 10);
}
- }
- if (strncasecmp(line, "bogomips\t", 9) == 0) {
+ } else if (strncasecmp(line, "bogomips\t", 9) == 0) {
handle_one_cpu(number, vendor, family, model);
set_max_cpu(number);
}
}
-
file.close();
perf_events = new perf_power_bundle();
-
if (!perf_events->add_event("power:cpu_idle")){
perf_events->add_event("power:power_start");
perf_events->add_event("power:power_end");
attachment.html
(text/html, 8 KB)
<html><body><div style="color:#000; background-color:#fff; font-family:times new roman, new york, times, serif;font-size:12pt"><div><span>Thanks,<br></span></div><div><span>this has gotten past the issue. I now get:<br></span></div><div><span><br></span></div><div><span>PowerTOP v2.0 needs the kernel to support the 'perf' subsystem<br>as well as support for trace points in the kernel:<br><br>CONFIG_PERF_EVENTS=y <br>CONFIG_PERF_COUNTERS=y<br>CONFIG_TRACEPOINTS=y<br>CONFIG_TRACING=y<br><br>all these except CONFIG_PERF_COUNTERS are already set, so i'll need to see if i can get a kernel built with that option on.</span></div><div><span><br></span></div><div><span>Will this patch make it into trunk?</span></div><div><span><br>Many thanks.</span></div><div><br></div> <div style="font-size: 12pt; font-family: "times new roman", "new york", "times", serif"> <div style="font-size: 12pt; font-family: "times new roman", "new york", "times", serif"> <div dir="ltr"> <font size="2" face="Arial"> <hr size="1"> <b><span style="font-weight:bold;">From:</span></b> Sergey Senozhatsky <[email protected]><br> <b><span style="font-weight: bold;">To:</span></b> Rui DaCosta <[email protected]> <br><b><span style="font-weight: bold;">Cc:</span></b> Arjan van de Ven <[email protected]>; Chris Ferron <[email protected]>; [email protected] <br> <b><span style="font-weight: bold;">Sent:</span></b> Sunday, 20 May 2012, 11:34<br> <b><span style="font-weight: bold;">Subject:</span></b> Re: [Powertop] segfault on Sheevaplug (ARM Kirkwood)<br> </font> </div> <br>On (05/20/12 02:19), Rui DaCosta wrote:<br>> Sure and thanks,<br>> (v1.13 worked fine btw)<br>> Processor : Feroceon 88FR131 rev 1 (v5l)<br>> BogoMIPS : 1191.11<br>> Features : swp half thumb fastmult edsp <br>> CPU implementer : 0x56<br>> CPU architecture: 5TE<br>> CPU variant : 0x2<br>> CPU part : 0x131<br>> CPU revision : 1<br>> <br>> Hardware : Marvell SheevaPlug Reference Board<br>> Revision : 0000<br>> Serial : 0000000000000000<br>> <br>> <br><br>Thanks,<br><br>Well, that's the problem. Current cpu info parser doesn't understand your<br>cpuinfo format. It awaits for sane values on special places. For example, word <br>"processor" should be followed by a number, not model name.<br><br> processor : 2<br> vendor_id : GenuineIntel<br> cpu family : 6<br> model : 37<br> bogomips : 4522.66<br><br>while cpuinfo on your system is totally different.<br><br>the following is untested patch (I'm a bit skeptical) plus I don't have <br>ARM device for testing.<br><br>---<br><br> src/cpu/cpu.cpp | 26 ++++++++++++++------------<br> 1 file changed, 14 insertions(+), 12 deletions(-)<br><br>diff --git a/src/cpu/cpu.cpp b/src/cpu/cpu.cpp<br>index 09d4a2d..143e18c 100644<br>--- a/src/cpu/cpu.cpp<br>+++ b/src/cpu/cpu.cpp<br>@@ -225,7 +225,7 @@ void enumerate_cpus(void)<br> ifstream file;<br> char line[1024];<br> <br>- int number = -1;<br>+ int number = 1;<br> char vendor[128];<br> int family = 0;<br> int model = 0;<br>@@ -236,7 +236,6 @@ void enumerate_cpus(void)<br> return;<br> <br> while (file) {<br>-<br> file.getline(line, sizeof(line));<br> if (strncmp(line, "vendor_id\t",10) == 0) {<br> char *c;<br>@@ -247,42 +246,45 @@ void enumerate_cpus(void)<br> c++;<br> strncpy(vendor,c, 127);<br> }<br>- }<br>- if (strncmp(line, "processor\t",10) == 0) {<br>+ } else if (strncmp(line, "processor\t",10) == 0) {<br> char *c;<br> c = strchr(line, ':');<br> if (c) {<br> c++;<br> number = strtoull(c, NULL, 10);<br> }<br>- }<br>- if (strncmp(line, "cpu family\t",11) == 0) {<br>+ } else if (strncmp(line, "Processor\t",10) == 0) {<br>+ char *c;<br>+ c = strchr(line, ':');<br>+ if (c) {<br>+ c++;<br>+ if (*c == ' ')<br>+ c++;<br>+ strncpy(vendor, c, 127);<br>+ }<br>+ } else if (strncmp(line, "cpu family\t",11) == 0) {<br> char *c;<br> c = strchr(line, ':');<br> if (c) {<br> c++;<br> family = strtoull(c, NULL, 10);<br> }<br>- }<br>- if (strncmp(line, "model\t",6) == 0) {<br>+ } else if (strncmp(line, "model\t",6) == 0) {<br> char *c;<br> c = strchr(line, ':');<br> if (c) {<br> c++;<br> model = strtoull(c, NULL, 10);<br> }<br>- }<br>- if (strncasecmp(line, "bogomips\t", 9) == 0) {<br>+ } else if (strncasecmp(line, "bogomips\t", 9) == 0) {<br> handle_one_cpu(number, vendor, family, model);<br> set_max_cpu(number);<br> }<br> }<br> <br>-<br> file.close();<br> <br> perf_events = new perf_power_bundle();<br>-<br> if (!perf_events->add_event("power:cpu_idle")){<br> perf_events->add_event("power:power_start");<br> perf_events->add_event("power:power_end");<br><br><br><br> </div> </div> </div></body></html>