Re: [Powertop] [PATCH v2] conditionally disable pci if not supported
Rajagopal Venkat <rajagopal.venkat at linaro.org> Mon, 25 Jun 2012 22:04:16 +0530
| Newsgroups | dev.linux.lists.powertop |
|---|---|
| Message-ID | <CA+Z25wWdE=FYXpTqcyebk4hwJpjvz9BodfrH__Tn1D47jgEj1Q@mail.gmail.com> |
On 25 June 2012 21:34, Arjan van de Ven <arjan(a)linux.intel.com> wrote: > On 6/25/2012 9:00 AM, Rajagopal Venkat wrote: > > <no commit message .. why? one sentence is cheap> > > Ok. Taken care. > > > > > diff --git a/src/lib.h b/src/lib.h > > index 588c023..d354151 100644 > > --- a/src/lib.h > > +++ b/src/lib.h > > @@ -30,6 +30,10 @@ > > #endif > > #include <stdint.h> > > > > +#if HAVE_CONFIG_H > > +#include "config.h" > > +#endif > > + > > #ifndef DISABLE_I18N > > #define _(STRING) gettext(STRING) > > #else > > > > > > ok this chunk I do not understand; > the rest of your patch looks very reasonable. > why is config.h inside an if ? > config.h is auto generated by autoconf and is not applicable for Android build. Yes. it should be wrapped in ifdef.
attachment.html
(text/html, 1.3 KB)
<br><br><div class="gmail_quote">On 25 June 2012 21:34, Arjan van de Ven <span dir="ltr"><<a href="mailto:[email protected]" target="_blank">[email protected]</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> On 6/25/2012 9:00 AM, Rajagopal Venkat wrote:<br> <br> <no commit message .. why? one sentence is cheap><br> <div class="im"><br></div></blockquote><div>Ok. Taken care. <br></div><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="im"> <br> ><br> > diff --git a/src/lib.h b/src/lib.h<br> > index 588c023..d354151 100644<br> > --- a/src/lib.h<br> > +++ b/src/lib.h<br> > @@ -30,6 +30,10 @@<br> > #endif<br> > #include <stdint.h><br> ><br> > +#if HAVE_CONFIG_H<br> > +#include "config.h"<br> > +#endif<br> > +<br> > #ifndef DISABLE_I18N<br> > #define _(STRING) gettext(STRING)<br> > #else<br> ><br> <br> <br> <br> </div>ok this chunk I do not understand;<br> the rest of your patch looks very reasonable.<br> why is config.h inside an if ?<br> </blockquote></div><br>config.h is auto generated by autoconf and is not applicable for Android build.<br>Yes. it should be wrapped in ifdef.<br>