Re: [Powertop] [PATCH] Make ncurses dependency optional

Kok, Auke-jan H <auke-jan.h.kok at intel.com> Thu, 19 Jul 2012 16:02:31 +0000
Newsgroups dev.linux.lists.powertop
Message-ID <CABsxX9+Hc2o7YqVcqZmUQBUdoaf7Ec2KmqwgRPJa2tjgt5o5kQ@mail.gmail.com>
On Thu, Jul 19, 2012 at 3:15 PM, Arjan van de Ven <arjan(a)linux.intel.com> wrote:
> On 7/18/2012 11:26 PM, Igor Zhbanov wrote:
>> Arjan van de Ven wrote:
>>> On 7/18/2012 7:54 AM, Igor Zhbanov wrote:
>>>> Make ncurses dependency optional. Provide --without-ncurses option
>>>> to configure.
>>> I'm sorry but this patch is disgusting;
>>> PowerTOP uses ncurses. Really.
>>>
>>> crapping ifdefs all over the codebase to pretend it does not, we're just
>>> really not going to do that this way.
>> I agree that lots of #ifdefs are ugly. But some mobile platforms doesn't
>> have ncurses.
>
> then maybe those mobile platforms should add ncurses?
>
> I did not realize Tizen lacked ncurses for example, sounds daft to be
> honest.

it doesn't:

https://review.tizen.org/git/?p=pkgs/n/ncurses.git

Auke