Re: [Powertop] [PATCH] remove -Werror from AM_INIT_AUTOMAKE

Patch applied
Thank You

On 06/17/2012 03:30 PM, Benedikt Morbach wrote:
> While this is nice while developing, it may cause
> various problems with distributed tarballs.
>
> A new automake version could add a warning, causing errors for distributions
> and users, who might need to patch configure.ac and thus run autoreconf.
>
> For example, we hit an error where a third party package (gettext) uses
> functionality (AM_PROG_MKDIR_P) which is deprecated in newer automake versions(1.12.1),
> causing the powertop build to fail.
>
> Since the problem lies elsewhere, it is stupid to fail for this while building powertop
> ---
>   configure.ac |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index 4da4eea..ff4cdea 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -3,7 +3,7 @@
>   
>   AC_PREREQ([2.68])
>   AC_INIT([powertop], [2.0], [powertop(a)lists.01.org])
> -AM_INIT_AUTOMAKE([-Wall -Werror foreign ])
> +AM_INIT_AUTOMAKE([-Wall foreign ])
>   AC_LANG([C++])
>   AC_CONFIG_FILES([Makefile src/Makefile pevent/Makefile po/Makefile.in doc/Makefile])
>   AC_CONFIG_SRCDIR([src/main.cpp])