Re: [Powertop] [PATCH] fix cpuidle state name parsing

Rajagopal Venkat <rajagopal.venkat at linaro.org> Fri, 13 Jul 2012 10:33:07 +0530
Newsgroups dev.linux.lists.powertop
Message-ID <CA+Z25wVhN65Z2wd90CktzyzMsKy4ZTHrwOeEtumXskbztE6cyA@mail.gmail.com>
Can someone consider this patch for merge?

On 23 June 2012 00:08, Rajagopal Venkat <rajagopal.venkat(a)linaro.org> wrote:

> parse cpuidle C state based on sysfs file entry(stateX)
> instead of state name/description
>
> Signed-off-by: Rajagopal Venkat <rajagopal.venkat(a)linaro.org>
> ---
>  src/cpu/abstract_cpu.cpp |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/cpu/abstract_cpu.cpp b/src/cpu/abstract_cpu.cpp
> index cd4eba0..72969fc 100644
> --- a/src/cpu/abstract_cpu.cpp
> +++ b/src/cpu/abstract_cpu.cpp
> @@ -147,7 +147,7 @@ void abstract_cpu::insert_cstate(const char
> *linux_name, const char *human_name,
>         strcpy(state->linux_name, linux_name);
>         strcpy(state->human_name, human_name);
>
> -       c = human_name;
> +       c = linux_name;
>         while (*c) {
>                 if (strcmp(linux_name, "active")==0) {
>                         state->line_level = LEVEL_C0;
> --
> 1.7.9.5
>
>
attachment.html (text/html, 1.4 KB)
Can someone consider this patch for merge?<br><br><div class="gmail_quote">On 23 June 2012 00:08, Rajagopal Venkat <span dir="ltr">&lt;<a href="mailto:[email protected]" target="_blank">[email protected]</a>&gt;</span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">parse cpuidle C state based on sysfs file entry(stateX)<br>
instead of state name/description<br>
<br>
Signed-off-by: Rajagopal Venkat &lt;<a href="mailto:[email protected]">[email protected]</a>&gt;<br>
---<br>
 src/cpu/abstract_cpu.cpp |    2 +-<br>
 1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/src/cpu/abstract_cpu.cpp b/src/cpu/abstract_cpu.cpp<br>
index cd4eba0..72969fc 100644<br>
--- a/src/cpu/abstract_cpu.cpp<br>
+++ b/src/cpu/abstract_cpu.cpp<br>
@@ -147,7 +147,7 @@ void abstract_cpu::insert_cstate(const char *linux_name, const char *human_name,<br>
        strcpy(state-&gt;linux_name, linux_name);<br>
        strcpy(state-&gt;human_name, human_name);<br>
<br>
-       c = human_name;<br>
+       c = linux_name;<br>
        while (*c) {<br>
                if (strcmp(linux_name, &quot;active&quot;)==0) {<br>
                        state-&gt;line_level = LEVEL_C0;<br>
<span class="HOEnZb"><font color="#888888">--<br>
1.7.9.5<br>
<br>
</font></span></blockquote></div><br>