Re: [Powertop] [PATCH] Get rid of ncurses' TRUE and FALSE

Arjan van de Ven wrote:
> On 7/18/2012 2:17 AM, Igor Zhbanov wrote:
>> Get rid of TRUE and FALSE ncurses' defines used for boolean variables
>> initialization. This fix also helps build without ncurses support.
> while I appreciate going to C++ true/false, building without ncurses
> isn't really a goal.
> (even on android, building ncurses is easy, and it does make the tool SO
> much more useful)
It is not good that C++ code depends on TRUE/FALSE defines
(defined in ncurses.h) in functions that are not related to ncurses.

P.S. I have merged Intel's and Linaro's repositories and will send patches for
review soon. I don't know why but Linaro wants to build PowerTOP without ncurses.
So I will send a patch that makes ncurses and libpci dependencies conditional.

-- 
Best regards,
Igor Zhbanov,
Expert Software Engineer,
phone: +7 (495) 797 25 00 ext 3806
e-mail: i.zhbanov(a)samsung.com

ASWG, Moscow R&D center, Samsung Electronics
12 Dvintsev street, building 1
127018, Moscow, Russian Federation