Re: [Powertop] [PATCH 1/2] devlist: Remove an unnecessary sprintf

On 09/18/2012 08:13 AM, Namhyung Kim wrote:
> The 'filename' is not used in the loop anymore.
>
> Signed-off-by: Namhyung Kim <namhyung(a)gmail.com>
> ---
>   src/devlist.cpp |    1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/src/devlist.cpp b/src/devlist.cpp
> index 5ec0a8b..828f47f 100644
> --- a/src/devlist.cpp
> +++ b/src/devlist.cpp
> @@ -147,7 +147,6 @@ void collect_open_devices(void)
>   					continue;
>   				dev->pid = strtoull(entry->d_name, NULL, 10);
>   				strncpy(dev->device, link, 251);
> -				sprintf(filename, "/proc/%s/comm", entry->d_name);
>   				strncpy(dev->comm, read_sysfs_string("/proc/%s/comm", entry->d_name).c_str(), 31);
>   				target->push_back(dev);
>   
Your patch has been merged
Thank You
-C