Re: [Powertop] [PATCH] Remove unneded escaping backslashes from CSS

On (09/14/12 14:15), Igor Zhbanov wrote:
> Dear Paul,
> 
> Paul Menzel wrote:
> >Am Freitag, den 14.09.2012, 13:46 +0400 schrieb Igor Zhbanov:
> >>Remove unneded escaping backslashes from CSS.
> >copying the summary into the body is not useful, because it adds no
> >further information.
> What to do when the commit summary describes all of the issue?
> Should I left body empty?
> >Please also add why the escaping was added beforehand and why it is
> >unneeded.
> I don't know why this particular escapes was added.
> In the file powertop.css there are lots of escaped quotes characters (")
> because later each line of this file will be wrapped inside of "LINE\n"
> to form a C array css[] in the file css.h.
> 
> But I don't know the reason for putting backslashes before slash in a
> closing
> </div> tag for jQuery append() method. I don't know any special handling
> of slashes in append() method.
> 


> Should I repost the patch with another description?
>

personally, I don't think so. it's rather hard to come up with commit message
when commit summary tells the whole story.
 
	-ss

> >>---
> >>  src/powertop.css |   16 ++++++++--------
> >>  1 files changed, 8 insertions(+), 8 deletions(-)
> >>
> >>diff --git a/src/powertop.css b/src/powertop.css
> >>index 087e384..5d303dc 100644
> >>--- a/src/powertop.css
> >>+++ b/src/powertop.css
> >>@@ -21,14 +21,14 @@ $(document).ready(function(){
> >>  	$('#tuning h2').addClass('hide');
> >>  	$('#tuning table').addClass('hide');
> >>-	$('#top').append('<div class=\"SystemButton\"   onclick=\"toggleSystem()\">System Info<\\/div>');
> >>-	$('#top').append('<div class=\"SummaryButton\"  onclick=\"toggleSummary()\">Summary<\\/div>');
> >>-	$('#top').append('<div class=\"CpuidleButton\"  onclick=\"toggleCpuidle()\">CPU Idle<\\/div>');
> >>-	$('#top').append('<div class=\"CpufreqButton\"  onclick=\"toggleCpufreq()\">CPU Frequency<\\/div>');
> >>-	$('#top').append('<div class=\"SoftwareButton\" onclick=\"toggleSoftware()\">Software info<\\/div>');
> >>-	$('#top').append('<div class=\"DeviceButton\"   onclick=\"toggleDevice()\">Device Info<\\/div>');
> >>-	$('#top').append('<div class=\"TuningButton\"   onclick=\"toggleTuning()\">Tuning<\\/div>');
> >>-	$('#top').append('<div class=\"AllButton\"      onclick=\"toggleAll()\">All<\\/div>');
> >>+	$('#top').append('<div class=\"SystemButton\"   onclick=\"toggleSystem()\">System Info</div>');
> >>+	$('#top').append('<div class=\"SummaryButton\"  onclick=\"toggleSummary()\">Summary</div>');
> >>+	$('#top').append('<div class=\"CpuidleButton\"  onclick=\"toggleCpuidle()\">CPU Idle</div>');
> >>+	$('#top').append('<div class=\"CpufreqButton\"  onclick=\"toggleCpufreq()\">CPU Frequency</div>');
> >>+	$('#top').append('<div class=\"SoftwareButton\" onclick=\"toggleSoftware()\">Software info</div>');
> >>+	$('#top').append('<div class=\"DeviceButton\"   onclick=\"toggleDevice()\">Device Info</div>');
> >>+	$('#top').append('<div class=\"TuningButton\"   onclick=\"toggleTuning()\">Tuning</div>');
> >>+	$('#top').append('<div class=\"AllButton\"      onclick=\"toggleAll()\">All</div>');
> >>  	$('#top .SummaryButton').toggleClass('pressed');
> >>      }
> 
> -- 
> Best regards,
> Igor Zhbanov,
> Expert Software Engineer,
> phone: +7 (495) 797 25 00 ext 3806
> e-mail: i.zhbanov(a)samsung.com
> 
> ASWG, Moscow R&D center, Samsung Electronics
> 12 Dvintsev street, building 1
> 127018, Moscow, Russian Federation
> 
> _______________________________________________
> PowerTop mailing list
> PowerTop(a)lists.01.org
> https://lists.01.org/mailman/listinfo/powertop
>