Re: [Printing-architecture] PAPPL 1.2rc1 (Supply levels)

Michael Sweet <[email protected]> Mon, 16 May 2022 10:46:18 -0400
Newsgroups	dev.linux.lists.printing-architecture
Message-ID	<[email protected]>
James,

What version of CUPS do you have on that system?  The change from HTTP_STATUS_REDIRECT_TEMPORARILY to HTTP_STATUS_FOUND happened back in 2017 (so CUPS 2.2/2.3 timeframe), so I might need to add some conditional code to still support the old name since I'm using the new name to avoid future breakage (current CUPS has a define from the old name to the new one...)  The hunan readable name changed when they updated the HTTP RFCs, and we *do* try to keep those in sync for sanity's sake... :(

A Github issue would be appreciated so that I don't forget this... :)

	https://github.com/michaelrsweet/pappl/issues

Thanks!


> On May 16, 2022, at 10:35 AM, James Cloos <[email protected]> wrote:
> ...
> it worked well for socket: on one of my boxen, but on my main
> workstation i got:
> 
> Compiling printer-webif.c...
> printer-webif.c: In function '_papplPrinterWebCancelAllJobs':
> printer-webif.c:64:42: error: 'HTTP_STATUS_FOUND' undeclared (first use in this function); did you mean 'HTTP_STATUS_GONE'?
>   64 |       papplClientRespondRedirect(client, HTTP_STATUS_FOUND, path);
>      |                                          ^~~~~~~~~~~~~~~~~
>      |                                          HTTP_STATUS_GONE
> printer-webif.c:64:42: note: each undeclared identifier is reported only once for each function it appears in
> printer-webif.c: In function '_papplPrinterWebCancelJob':
> printer-webif.c:169:44: error: 'HTTP_STATUS_FOUND' undeclared (first use in this function); did you mean 'HTTP_STATUS_GONE'?
>  169 |         papplClientRespondRedirect(client, HTTP_STATUS_FOUND, path);
>      |                                            ^~~~~~~~~~~~~~~~~
>      |                                            HTTP_STATUS_GONE
> printer-webif.c: In function '_papplPrinterWebDelete':
> printer-webif.c:784:42: error: 'HTTP_STATUS_FOUND' undeclared (first use in this function); did you mean 'HTTP_STATUS_GONE'?
>  784 |       papplClientRespondRedirect(client, HTTP_STATUS_FOUND, "/");
>      |                                          ^~~~~~~~~~~~~~~~~
>      |                                          HTTP_STATUS_GONE
> printer-webif.c: In function '_papplPrinterWebReprintJob':
> printer-webif.c:1414:50: error: 'HTTP_STATUS_FOUND' undeclared (first use in this function); did you mean 'HTTP_STATUS_GONE'?
> 1414 |               papplClientRespondRedirect(client, HTTP_STATUS_FOUND, path);
>      |                                                  ^~~~~~~~~~~~~~~~~
>      |                                                  HTTP_STATUS_GONE
> make[1]: *** [../Makedefs:75: printer-webif.o] Error 1
> make: *** [Makefile:28: all] Error 1
> 
> 
> make -k showed a number of similar issues in other files.
> 
> obviously some dependency is too old; where does HTTP_STATUS_FOUND come
> from?
> 
> in any case it looks like configure fail to notice that said dep is too
> old.
> 
> -JimC
> --
> James Cloos <[email protected]>         OpenPGP: 0x997A9F17ED7DAEA6
> 
> 

________________________
Michael Sweet
signature.asc (application/pgp-signature, 833 B)