Re: A couple of questions regarding IPP specs
Zdenek Dohnal <[email protected]> Fri, 22 Mar 2024 07:14:30 +0100
| Newsgroups | dev.linux.lists.printing-architecture |
|---|---|
| Message-ID | <[email protected]> |
Sending this in plain text... On 3/22/24 06:30, Zdenek Dohnal wrote: > > Hi all, > > On 3/21/24 19:41, Michael Sweet wrote: >>> In the CUPS sources, in the ippFindNextAttribute(), I see name is used twice for comparison, with strcmp() in one place and with _cups_strcasecmp() in another place... >> That would be a bug, they should both be using strcmp. It dates from before 2011 so I'll have to do some serious digging into the old Subversion repository to get that history... > > Fixed in master and 2.4.x: > > https://github.com/OpenPrinting/cups/commit/1aa0b7bd778 > > https://github.com/OpenPrinting/cups/commit/d5b249e3c74f0 > > I hope you don't mind pushing this directly without PR - I guessed the > issue was discussed here, so I took the initiative. > > > Happy Friday, > > > Zdenek > > -- > Zdenek Dohnal > Senior Software Engineer > Red Hat, BRQ-TPBC -- Zdenek Dohnal Senior Software Engineer Red Hat, BRQ-TPBC