Re: [PATCH net-next v5 00/16] net: introduce QUIC infrastructure and core subcomponents
Xin Long <[email protected]> Fri, 28 Nov 2025 17:21:30 -0500
| Newsgroups | dev.linux.lists.quic,dev.linux.lists.kernel-tls-handshake,org.kernel.vger.linux-cifs,org.kernel.vger.netdev |
|---|---|
| Message-ID | <CADvbK_crxSB+TwDgEtjV6TUEeO9VYtsE6rqy7L_=rzoDrCfORQ@mail.gmail.com> |
On Thu, Nov 27, 2025 at 9:30 PM Jakub Kicinski <[email protected]> wrote: > > On Mon, 24 Nov 2025 09:28:13 -0500 Xin Long wrote: > > The QUIC protocol, defined in RFC 9000, is a secure, multiplexed transport > > built on top of UDP. It enables low-latency connection establishment, > > stream-based communication with flow control, and supports connection > > migration across network paths, while ensuring confidentiality, integrity, > > and availability. > > Please look thru the Claude review and address the legit complaints: > > https://netdev-ai.bots.linux.dev/ai-review.html?id=8ac157b3-6222-4e89-ac52-28e4ca52d6c4 > > If the tool is confused but not in an dumb way - it may be worth adding > a relevant comment or info in the commit message. Otherwise a note under > --- would be appreciated to avoid maintainers having to re-check the > comments you already considered and disproved. Thanks for the link. I just went through the tool’s report. It found one real issue in quic_packet_backlog_work(), which I’ll fix. The other items aren’t actual problems, and I’ll add some inline comments or --- notes to explain them. > > Thanks for adding the MAINTAINERS entry, two notes on that: > - the entries must be sorted, so you need to move it down under Q > instead of putting it next to SCTP > - you seem to have copy/pasted the uAPI path for SCTP to the entry > instead of QUIC ;) You're right, thanks!