Re: [PATCH net-next v6 02/16] net: build socket infrastructure for QUIC protocol

Paolo Abeni <[email protected]> Thu, 8 Jan 2026 15:40:02 +0100
Newsgroups dev.linux.lists.quic,dev.linux.lists.kernel-tls-handshake,org.kernel.vger.linux-cifs,org.kernel.vger.netdev
Message-ID <[email protected]>
On 1/5/26 3:04 PM, Xin Long wrote:
> +static int quic_net_proc_init(struct net *net)
> +{
> +	quic_net(net)->proc_net = proc_net_mkdir(net, "quic", net->proc_net);
> +	if (!quic_net(net)->proc_net)
> +		return -ENOMEM;
> +
> +	if (!proc_create_net_single("snmp", 0444, quic_net(net)->proc_net,
> +				    quic_snmp_seq_show, NULL))
> +		goto free;
> +	return 0;
> +free:

Minor nits: I think an empty line before the label makes the code more
readable, and I would prefer #if IS_ENABLED() over #ifdef.

Other than that:

Acked-by: Paolo Abeni <[email protected]>