Re: [PATCH net-next v6 05/16] quic: provide quic.h header files for kernel and userspace

Xin Long <[email protected]> Thu, 8 Jan 2026 12:44:37 -0500
Newsgroups dev.linux.lists.quic,dev.linux.lists.kernel-tls-handshake,org.kernel.vger.linux-cifs,org.kernel.vger.netdev
Message-ID <CADvbK_c2YE8KfXE2KP0=a_zaUm-AWNOwpmyeDCQURA3AtbDpOQ@mail.gmail.com>
On Thu, Jan 8, 2026 at 10:01 AM Paolo Abeni <[email protected]> wrote:
>
> On 1/5/26 3:04 PM, Xin Long wrote:
> > This commit adds quic.h to include/uapi/linux, providing the necessary
> > definitions for the QUIC socket API. Exporting this header allows both
> > user space applications and kernel subsystems to access QUIC-related
> > control messages, socket options, and event/notification interfaces.
> >
> > Since kernel_get/setsockopt() is no longer available to kernel consumers,
> > a corresponding internal header, include/linux/quic.h, is added.
>
> Re-adding kernel_get/setsockopt() variants after removal, but just for a
> single protocol is a bit ackward. The current series does not have any
> user.
>
> Do such helpers save a lot of duplicate code? Otherwise I would instead
> expose quic_do_{get,set}sockopt().
>
Not much, just when using quic_do_{get,set}sockopt(), KERNEL_SOCKPTR()
will be used around the optval and optlen.

It should be fine to change to expose quic_do_{get,set}sockopt().

Thanks.