Re: [PATCH net] net: phy: skip EEE advertisement write when autoneg is disabled
Andrew Lunn <[email protected]>
| Newsgroups | dev.linux.lists.regressions,org.kernel.vger.linux-kernel,org.kernel.vger.netdev,org.kernel.vger.stable |
|---|---|
| Message-ID | <[email protected]> |
> On at least the Broadcom BCM54213PE PHY, however, the indirect MMD
> write triggered from this path while the link is currently forced
> (autoneg off) disturbs the receive datapath
> + /* MMD AN advertisements are only consumed during autoneg. */
> + if (phydev->autoneg == AUTONEG_DISABLE)
> + return 0;
You are not adding this condition because it is not consumed, but
because it is consumed and then bad things happen. Please could you
make the comment accurate.
Andrew
---
pw-bot: cr