Re: [PATCH v2 2/2] Revert "media: renesas: vsp1: brx: Fix format propagation"

On Wed, May 27, 2026 at 09:48:17AM +0200, Laurent Pinchart wrote:
> On Wed, May 27, 2026 at 09:35:03AM +0200, Thorsten Leemhuis wrote:
> > On 5/6/26 23:56, Laurent Pinchart wrote:
> > > This reverts commit 937f3e6b51f1cea079be9ba642665f2bf8bcc31f.
> > > 
> > > The change to format propagation in the BRx broke configuration of the
> > > DRM pipeline. Revert it to fix the regression.
> > 
> > Laurent, is this still on your radar? From the outside it looks like
> > this fix for the 7.1 regression should ideally go to Linus this week, as
> > he ideally wants all known regression fixed by -rc6.
> > 
> > But it's easy to miss things from the outside, so if this is not a
> > proper regression, the revert obsolete, or something like that, just
> > mention it.
> 
> Thank you for the reminder. Hans, Mauro, this series seems to not have
> been merged in the media fixes branch. Could you pick it up ?

I have sent a pull request:

https://lore.kernel.org/linux-media/[email protected]

> > > The original commit was meant to fix a v4l2-compliance failure, with no
> > > known userspace applications being affected beside test tools. Reverting
> > > is the simplest option, a more comprehensive fix can be developed (and
> > > tested more thoroughly) later.
> > > 
> > > Reported-by: Lad Prabhakar <[email protected]>
> > > Closes: https://lore.kernel.org/linux-media/CA+V-a8t481xuwava0nb7uY9CUPqFWZ_8EP0xrK3BgumP7HDcLg@mail.gmail.com
> > > Fixes: 937f3e6b51f1 ("media: renesas: vsp1: brx: Fix format propagation")
> > > Signed-off-by: Laurent Pinchart <[email protected]>
> > > ---
> > >  drivers/media/platform/renesas/vsp1/vsp1_brx.c | 10 ++--------
> > >  1 file changed, 2 insertions(+), 8 deletions(-)
> > > 
> > > diff --git a/drivers/media/platform/renesas/vsp1/vsp1_brx.c b/drivers/media/platform/renesas/vsp1/vsp1_brx.c
> > > index b1a2c68e9944..9d93cb8b8e82 100644
> > > --- a/drivers/media/platform/renesas/vsp1/vsp1_brx.c
> > > +++ b/drivers/media/platform/renesas/vsp1/vsp1_brx.c
> > > @@ -156,20 +156,14 @@ static int brx_set_format(struct v4l2_subdev *subdev,
> > >  		compose->height = format->height;
> > >  	}
> > >  
> > > -	/*
> > > -	 * Propagate the format code to all pads, and the whole format to the
> > > -	 * source pad.
> > > -	 */
> > > +	/* Propagate the format code to all pads. */
> > >  	if (fmt->pad == BRX_PAD_SINK(0)) {
> > >  		unsigned int i;
> > >  
> > > -		for (i = 0; i < brx->entity.source_pad; ++i) {
> > > +		for (i = 0; i <= brx->entity.source_pad; ++i) {
> > >  			format = v4l2_subdev_state_get_format(state, i);
> > >  			format->code = fmt->format.code;
> > >  		}
> > > -
> > > -		format = v4l2_subdev_state_get_format(state, i);
> > > -		*format = fmt->format;
> > >  	}
> > >  
> > >  done:

-- 
Regards,

Laurent Pinchart