Re: kernel NULL pointer dereference in quirk_clear_strap_no_soft_reset_dev2_f0 -> amd_smn_read

Marek Marczykowski-Górecki <[email protected]>
Newsgroups dev.linux.lists.regressions,org.kernel.vger.linux-kernel
Message-ID <aiNF5HXO4CksO_NE@mail-itl>
On Fri, Jun 05, 2026 at 02:15:43PM -0700, Borislav Petkov wrote:
> On Fri, Jun 05, 2026 at 10:23:18PM +0200, Marek Marczykowski-Górecki wrote:
> > Instead of the series? No, that's not enough. amd_smn_read() is called
> > from quirk_clear_strap_no_soft_reset_dev2_f0, so it would still hit NULL
> > at amd_roots in __amd_smn_rw(). But if you mean instead of the first
> > patch (but apply the second as is), it should work. I don't have
> > affected hardware, but I'll ask the affected user to test this version.
> 
> amd_smn_read() should not happen in guests. It is that simple.

Well, it clearly happens, see the call trace in the first message of the
thread...
Do you suggest the fix should change
quirk_clear_strap_no_soft_reset_dev2_f0()?

-- 
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
signature.asc (application/pgp-signature, 488 B)
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmojReQACgkQ24/THMrX
1yxDJQf/XRyqtYhx+fwvFXRKHvxjqx9H7F1a+VVKnhzWlqc5SF6a7GFCZMNOwtLZ
W6ywU582sAv8lYqT0zKlZ6+8m3RtLOKmQSGwAjgpbVjsODAhCu5C09Kb1m3nHolO
qyrQj26sHb3WzXYWK6+7r2MR6/PUwMN8AkgCy/+0TVT0acYDFxWSaSpLC45yODqh
RGgzCfTvpWDW2jLRBPFDnB7VwBYlPYcRKvczR9R6tQ7XDwEpXeUcjzTzuw8QoJNq
Lh6a1IcoJD4i7fDRXhzNojCuoogacXnfsVIxrkTY0e+EQOftTxjLZZd/mqYtcc9O
dK9H4H7FInS5Ncn7+XR2LdK5t3sLJA==
=KNKR
-----END PGP SIGNATURE-----
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.