Re: [PATCH wireless-next] wifi: mt76: fix MAC address for non OF pcie cards

Tobias Klausmann <[email protected]> Mon, 6 Jul 2026 10:19:18 +0200

Newsgroups	dev.linux.lists.regressions,org.infradead.lists.linux-arm-kernel,org.infradead.lists.linux-mediatek,org.kernel.vger.linux-kernel,org.kernel.vger.linux-wireless
Message-ID	<[email protected]>

Hi! 

On Mon, 06 Jul 2026, Thorsten Leemhuis wrote:
> On 6/30/26 23:02, Rosen Penev wrote:
> > If seems the check for err is wrong as the proper macaddr gets written
> > to from the EEPROM itself. Meaning checking err from of_get_mac_address is
> > wrong as the proper macaddr has been written by this point.
> 
> By our submission guidelines and requests from Linus this afaics should
> also contain:
> 
> Reported-by: Klara Modin <[email protected]>
> Closes: https://lore.kernel.org/all/[email protected]/
> Reported-by: Tobias Klausmann <[email protected]>
> Closes:
> https://lore.kernel.org/linux-wireless/[email protected]/
> 
> Both of them now CCed, too, to give them a chance to provide a "Tested-by:".
> 
> > Fixes: 31ee1582717e ("wifi: mt76: fix of_get_mac_address error handling")

Indeed:

Tested-by: Tobias Klausmann <[email protected]>

I've been running 7.2.0-rc1+the revert for a few days now with zero
issues (not that I expected any).

Best,
Tobias