Re: [Bug 221606] r8169: PCIe AER errors and recovery failure after recent driver changes

On 6/10/26 19:58, Lasse Bjerre wrote:
> 
> Absolutely, I have attached a full dmesg from a fresh boot as well as
> the output of lspci.
> Important to note (should have done so earlier) that I have manually
> turned on l1_1_aspm using a udev rule. It is not on by default, but has
> worked flawlessly until the issue in question.

Hmm, seems nothing happened since then -- or was there progress and I
just missed it? If not: is this intentional (due to manually enabling
l1_1_aspm maybe?), or did this regression fall through the cracks?

Ciao, Thorsten
> ------------------------------------------------------------------------
> *From:* Javen <[email protected]>
> *Sent:* 04 June 2026 11:01
> *To:* Heiner Kallweit <[email protected]>
> *Cc:* [email protected] <[email protected]>; Lasse Bjerre
> <[email protected]>
> *Subject:* RE: [Bug 221606] r8169: PCIe AER errors and recovery failure
> after recent driver changes
>  
>>On 03.06.2026 09:44, [email protected] wrote:
>>> https://bugzilla.kernel.org/show_bug.cgi?id=221606 <https://
> bugzilla.kernel.org/show_bug.cgi?id=221606>
>>>
>>> --- Comment #2 from [email protected] ---
>>> Commit 9ab94a32af704fa9c873094283ae8744a07baf25 (r8169: enable LTR
>>> support) seems to be the issue. Running the commit before this doesn't
>>> give me any AER errors and everything seems to behave normally.
>>>
>>Bisecting the reported issue points to one of your commits.
>>Could you please check with the user?
> 
> Hi, Heiner, Lasse
> 
> Thanks for reporting this issue.
> 
> Currently, we haven't received any similar reports from our customers,
> and I am unable to reproduce this AER error on my local test platforms.
> 
> Could you please provide some more detailed information? The full dmesg
> log will help me check the exact AER error messages and the boot
> context. Also the output of sudo lspci -vvv. I need this to check the
> exact platform information, PCIe topology, and the LTR/ASPM capabilities
> of both your Root Port and the Realtek NIC.
> 
> While reviewing the initialization flow, I noticed a potential logic
> contradiction. If rtl_aspm_is_safe(tp) returns false, the driver
> disables L1 at the PCIe core level, but tp->aspm_manageable might still
> be set to true. This could cause the driver to incorrectly enable ASPM/
> LTR in the MAC registers later, creating a hardware state mismatch (PCIe
> L1 disabled, but MAC LTR enabled) which usually leads to AER.
> 
> Could you please test if the following patch fixes the AER error on your
> side?
> 
> -       if (enable && tp->aspm_manageable) {
> +       if (enable && tp->aspm_manageable && rtl_aspm_is_safe(tp)) {
> 
> Thanks,
> BRs,
> Javen