Re: [Regression] Kernel 7.2-rc : thunderbolt crash on startup

Thorsten Leemhuis wrote:
> On 7/8/26 22:09, Woody Suwalski wrote:
>> Re: commit f5cc545f59699549adbaa4084149f8247865a51d
>> Author: Mika Westerberg <[email protected]>
>> Date:   Wed Nov 19 12:53:58 2025 +0200
>>
>>      thunderbolt: Wait for tb_domain_release() to complete when driver is
>> removed
>>
>> ====================
>>
>> Mika, starting with7.2-rc1 the boot on an old Apple MacBookPro and
>> MacBook Air has been problematic - the thunderbolt driver crash may stop
>> boot or let it boot in somehow unstable state.
> Seems this fell through the cracks (due to vacations or something I
> assume -- so no worries!), but to ensure this is not totally forgotten:
>
> Woddy, does this still happen with 7.2-rc5? And is the fix you proposed
> still helping?
> https://lore.kernel.org/lkml/[email protected]/
>
> Ciao, Thorsten
>
Hi Thorsten,

Mika is now back from holidays and we are starting to discuss the fix.
So most likely it will now be cleared in an one or two rc releases :-)

Thanks, Woody
>> The issue is the domain_release()/complete() crash as called during boot.
>>
>> Just disabling the
>>
>> complete(&nhi->domain_released);
>>
>> line will allow system to boot OK, however (as designed in your patch)
>> on shutdown system will hang waiting for completion.
>>
>> I am not sure if the workaround should be to detect that
>> domain_release() is called during startup, or perhaps to fix the problem
>> on the kernel scheduler level?
>>
>> If you have any ideas or patches, let me know...
>>
>> Thanks, Woody Suwalski
>> [email protected]
>>
>> =========================
>> [   10.531967] [   T2588] bcma-pci-bridge 0000:03:00.0: bus0: Core 2
>> found: PCIe (manuf 0x4BF, id 0x820, rev 0x1
>> 3, class 0x0)
>> [   10.570223] [   T2604] ACPI: bus type thunderbolt registered
>> [   10.580666] [   T2604] BUG: unable to handle page fault for address:
>> fffffffffffffff8
>> [   10.580745] [   T2604] #PF: supervisor read access in kernel mode
>> [   10.580796] [   T2604] #PF: error_code(0x0000) - not-present page
>> [   10.580844] [   T2604] PGD 2ec19067 P4D 2ec19067 PUD 2ec1b067 PMD 0
>> [   10.580915] [   T2604] Oops: Oops: 0000 [#1] SMP NOPTI
>> [   10.580929] [   T2603] acpi ACPI0001:00: SBS HC: offset = 0x20,
>> query_bit = 0x10
>> [   10.580968] [   T2604] CPU: 3 UID: 0 PID: 2604 Comm: (udev-worker)
>> Tainted: G S                  7.2-pingu #0~rc1 PREEMPT(full)
>> 9f8aaa247129d19aebb6b0d19f7b648b1f9f7f36
>> [   10.581126] [   T2604] Tainted: [S]=CPU_OUT_OF_SPEC
>> [   10.581165] [   T2604] Hardware name: Apple Inc. MacBookPro8,1/
>> Mac-94245B3640C91C81, BIOS MBP81.88Z.0050.B00.1804101331 04/10/18
>> [   10.581248] [   T2604] RIP: 0010:complete+0x3a/0x70
>> [   10.581301] [   T2604] Code: 61 c8 00 48 89 c5 8b 03 83 f8 ff 74 05
>> 83 c0 01 89 03 48 8b 53 10 48 8d 43 10 48 39 c2 74 29 48 8b 5b 10 31 d2
>> be 03 00 00 00 <48> 8b 7b f8 e8 4d e9 fd ff 48 8b 13 48 8b 43 08 48 89
>> 42 08 48 89
>> [   10.581441] [   T2604] RSP: 0018:ffff92720020ba98 EFLAGS: 00010046
>> [   10.581496] [   T2604] RAX: ffff8c82c6a2b3b0 RBX: 0000000000000000
>> RCX: 000000000000000c
>> [   10.581559] [   T2604] RDX: 0000000000000000 RSI: 0000000000000003
>> RDI: ffff8c82c6a2b3a8
>> [   10.581621] [   T2604] RBP: 0000000000000282 R08: 0000000000000000
>> R09: 0000000000000000
>> [   10.581681] [   T2604] R10: 0000000000000001 R11: ffff8c832ba20d80
>> R12: ffff8c82c6a2b3a8
>> [   10.581744] [   T2604] R13: ffff8c82c81f02b0 R14: 0000000000000000
>> R15: ffff8c82c6e53148
>> [   10.581808] [   T2604] FS:  00007ffaf52c99c0(0000)
>> GS:ffff8c839ad88000(0000) knlGS:0000000000000000
>> [   10.581881] [   T2604] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
>> [   10.581935] [   T2604] CR2: fffffffffffffff8 CR3: 0000000105596002
>> CR4: 00000000000606f0
>> [   10.581999] [   T2604] Call Trace:
>> [   10.582032] [   T2604]  <TASK>
>> [   10.582061] [   T2604]  device_release+0x3a/0x90
>> [   10.582112] [   T2604]  kobject_put+0x8a/0x230
>> [   10.582166] [   T2604]  icm_probe+0xf2/0x550 [thunderbolt
>> 2f2c536023810e0da91d9b6d6a63a9f9bf553e73]
>> [   10.582415] [   T2604]  nhi_probe+0x196/0x390 [thunderbolt
>> 2f2c536023810e0da91d9b6d6a63a9f9bf553e73]
>> [   10.582620] [   T2604]  local_pci_probe+0x3c/0x90
>> [   10.582668] [   T2604]  pci_device_probe+0xb0/0x1d0
>> [   10.582715] [   T2604]  ? sysfs_do_create_link_sd+0x69/0xd0
>> [   10.582778] [   T2604]  really_probe+0xd1/0x3e0
>> [   10.582826] [   T2604]  ? __pfx___driver_attach+0x10/0x10
>> [   10.582878] [   T2604]  __driver_probe_device+0x80/0x180
>> [   10.582931] [   T2604]  driver_probe_device+0x1a/0x80
>> [   10.582983] [   T2604]  __driver_attach+0xca/0x1f0
>> [   10.583031] [   T2604]  bus_for_each_dev+0x6d/0xc0
>> [   10.583079] [   T2604]  bus_add_driver+0x11b/0x240
>> [   10.583128] [   T2604]  driver_register+0x50/0x100
>> [   10.583178] [   T2604]  ? __pfx_init_module+0x10/0x10 [thunderbolt
>> 2f2c536023810e0da91d9b6d6a63a9f9bf553e73]
>> [   10.583404] [   T2604]  nhi_init+0x30/0xff0 [thunderbolt
>> 2f2c536023810e0da91d9b6d6a63a9f9bf553e73]
>> [   10.583606] [   T2604]  ? __pfx_init_module+0x10/0x10 [thunderbolt
>> 2f2c536023810e0da91d9b6d6a63a9f9bf553e73]
>> [   10.583805] [   T2604]  do_one_initcall+0x6b/0x2c0
>> [   10.583851] [   T2604]  ? do_init_module+0x1d/0x270
>> [   10.583895] [   T2604]  do_init_module+0x5b/0x270
>> [   10.583935] [   T2604]  init_module_from_file+0xc3/0xe0
>> [   10.583982] [   T2604]  idempotent_init_module+0xf7/0x2e0
>> [   10.584029] [   T2604]  __x64_sys_finit_module+0x68/0xe0
>> [   10.584075] [   T2604]  do_syscall_64+0xc2/0x550
>> [   10.586162] [   T2604]  entry_SYSCALL_64_after_hwframe+0x76/0x7e
>> [   10.588198] [   T2604] RIP: 0033:0x7ffaf5e277b9
>> [   10.590222] [   T2604] Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f
>> 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b
>> 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 27 66 0d 00 f7 d8
>> 64 89 01 48
>> [   10.594678] [   T2604] RSP: 002b:00007ffd1d772f38 EFLAGS: 00000246
>> ORIG_RAX: 0000000000000139
>> [   10.597004] [   T2604] RAX: ffffffffffffffda RBX: 0000561fac083800
>> RCX: 00007ffaf5e277b9
>> [   10.599213] [   T2604] RDX: 0000000000000000 RSI: 00007ffaf455a44d
>> RDI: 0000000000000027
>> [   10.601423] [   T2604] RBP: 0000000000000000 R08: 0000000000000000
>> R09: 0000561fac003030
>> [   10.603602] [   T2604] R10: 0000000000000000 R11: 0000000000000246
>> R12: 00007ffaf455a44d
>> [   10.605753] [   T2604] R13: 0000000000020000 R14: 0000561fac082060
>> R15: 0000000000000000
>> [   10.607706] [   T2604]  </TASK>
>> [   10.609330] [   T2604] Modules linked in: sbshc bcma(+)
>> thunderbolt(+) usb_common sg efi_pstore nvme_fabrics fuse configfs
>> efivarfs dmi_sysfs autofs4
>> [   10.610939] [   T2604] CR2: fffffffffffffff8
>> [   10.612390] [   T2604] ---[ end trace 0000000000000000 ]---
>> [   10.615077] [   T2588] bcma-pci-bridge 0000:03:00.0: bus0: Bus
>> registered
>>
>>