Re: [PATCH mt76] wifi: mt76: mt792x: drop redundant napi_disable() in unregister path
Thorsten Leemhuis <[email protected]>
| Newsgroups | dev.linux.lists.regressions,org.kernel.vger.linux-kernel,org.kernel.vger.linux-wireless |
|---|---|
| Message-ID | <[email protected]> |
On 7/28/26 02:20, Mikhail Gavrilov wrote:
> Commit 13b7e6a96a00 ("wifi: mt76: Disable napi when removing device")
> made mt76_dma_cleanup() disable every RX NAPI instance before deleting
> it. mt7921e_unregister_device() and mt7925e_unregister_device() already
> disable the very same instances and only afterwards call
> mt792x_dma_cleanup() -> mt76_dma_cleanup(), so each instance is now
> disabled twice.
> [...]
> Fixes: 13b7e6a96a00 ("wifi: mt76: Disable napi when removing device")
> Reported-by: Bert Karwatzki <[email protected]>
> Closes: https://lore.kernel.org/all/[email protected]/
> Suggested-by: Nicolas Cavallari <[email protected]>
> Signed-off-by: Mikhail Gavrilov <[email protected]>
> ---
>
> I hit the same hang on an ASRock B650I Lightning WiFi with MT7922
> (mt7921e) and bisected it to the same commit. mt7921e has the same
> duplicated napi_disable() as mt7925e, so this covers both; it is
> Nicolas' suggestion from [1] extended to mt7921e and with the now
> unused 'int i' removed.
TWIMC, there is another report about reboot/shutdown problems with mt76
that was bisected to the commit mentioned above:
https://bugzilla.kernel.org/show_bug.cgi?id=221818
Pointed the reporter to this proposed fix two days ago, but no reply yet.
Ciao, Thorsten