[PATCH 1/2] Add rpdfs_unlink()
Valerie Aurora <[email protected]> Tue, 24 Feb 2026 17:41:56 +0100
| Newsgroups | dev.linux.lists.rpdfs-devel |
|---|---|
| Message-ID | <[email protected]> |
Copied from rpdfs_rename() and the extra bits removed. Signed-off-by: Valerie Aurora <[email protected]> --- fs/rpdfs/dir.c | 51 ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 51 insertions(+) diff --git a/fs/rpdfs/dir.c b/fs/rpdfs/dir.c index 115f879d8fb1..9b33453ad5f6 100644 --- a/fs/rpdfs/dir.c +++ b/fs/rpdfs/dir.c @@ -491,6 +491,56 @@ static struct dentry *rpdfs_mkdir(struct mnt_idmap *idmap, struct inode *dir, return ERR_PTR(create_and_instantiate_new(idmap, dir, dentry, S_IFDIR | mode)); } +static int rpdfs_unlink(struct inode *dir, struct dentry *dentry) +{ + struct rpdfs_fs_info *rfi = RPDFS_INODE_FS(dir); + struct inode *inode = d_inode(dentry); + struct key_dent *kd = NULL; + DECLARE_RPDFS_TXN(txn); + int ret; + + kd = alloc_key_dent(dentry, inode); + if (!kd) { + ret = -ENOMEM; + goto out; + } + + /* prepare all the blocks for in the txn */ + do { + ret = rpdfs_inode_txn_prepare(rfi, &txn, dir, RBAF_WRITE) ?: + rpdfs_inode_txn_prepare(rfi, &txn, inode, RBAF_WRITE) ?: + prepare_remove_entry(rfi, &txn, dir, kd); + } while (rpdfs_txn_retry(rfi, &txn, &ret)); + if (ret < 0) + goto out; + + /* apply changes to block structures */ + apply_remove_entry(rfi, &txn, dir, kd); + + /* update vfs inodes: first dir sizes and times */ + i_size_write(dir, i_size_read(dir) - dentry->d_name.len); + inode_set_mtime_to_ts(dir, inode_set_ctime_current(dir)); + + /* now inode nlink and times */ + if (inode->i_nlink == 0) + pr_warn("deleting inode %.*s with link count already 0", + dentry->d_name.len, dentry->d_name.name); + else + drop_nlink(inode); + inode_set_ctime_current(inode); + + /* update block storage of vfs inodes */ + rpdfs_inode_txn_update(rfi, &txn, dir); + rpdfs_inode_txn_update(rfi, &txn, inode); + + ret = 0; +out: + rpdfs_txn_reset(rfi, &txn); + kfree(kd); + + return ret; +} + /* * The vfs has verified the cached directories. Our inode refresh will * fail if the inodes have been reused, so we don't have to test if @@ -680,6 +730,7 @@ const struct inode_operations rpdfs_dir_iops = { .lookup = rpdfs_lookup, .mkdir = rpdfs_mkdir, .rename = rpdfs_rename, + .unlink = rpdfs_unlink, }; const struct file_operations rpdfs_dir_fops = { -- 2.49.0