Re: [PATCH v2 2/2] serial: 8250_mtk: honor DT serial aliases
"Carlo Caione" <[email protected]>
| Newsgroups | dev.linux.lists.sashiko-reviews,org.kernel.vger.linux-devicetree |
|---|---|
| Message-ID | <[email protected]> |
On Mon Jul 27, 2026 at 9:51 AM CEST, sashiko-bot wrote: > Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: > > Pre-existing issues: > - [High] The driver registers the 8250 port before enabling runtime PM, violating TTY subsystem guidelines and causing circular dependencies during probe. > - [High] An integer overflow in baud rate calculation can cause a divide-by-zero kernel panic and incorrect fractional divisor calculations. [...] > [Severity: High] > This is a pre-existing issue, but while looking at mtk8250_probe(), I noticed [...] > [Severity: High] > This is another pre-existing issue, but I noticed a potential integer overflow This is annoying. I'm NOT fixing pre-existing issue. There will always be pre-existing issue. -- Carlo Caione