Re: [PATCH v3 3/5] dt-bindings: gpu: powervr-rogue: Add MediaTek MT8173 GPU

On Mon, Jul 27, 2026 at 5:26 PM <[email protected]> wrote:
>
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] Schema validation failure for MT8173 GPU due to inherited power-domain constraints
> --
>
> --- Patch [3]: [PATCH v3 3/5] dt-bindings: gpu: powervr-rogue: Add MediaTek MT8173 GPU ---
> commit 560e4cee0c5fbc6b0c5d09c24c260e205ca79e47
> Author: Chen-Yu Tsai <[email protected]>
>
> dt-bindings: gpu: powervr-rogue: Add MediaTek MT8173 GPU
>
> The MediaTek MT8173 comes with a PowerVR Rogue GX6250, which is one
> of the Series6XT GPUs, another sub-family of the Rogue family.
>
> [1] https://lore.kernel.org/dri-devel/[email protected]/
>
> > diff --git a/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml
> > index a1f54dbae3f31..53131cd4cc2a3 100644
> > --- a/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml
> > +++ b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml
> > @@ -15,6 +15,7 @@ properties:
> >      oneOf:
> >        - items:
> >            - enum:
> > +              - mediatek,mt8173-gpu
>
> [Severity: Medium]
> Will this cause schema validation failures for the MT8173 GPU node?
>
> By using img,img-gx6250 as the fallback compatible string here, it seems this
> will trigger the allOf conditional block lower in the file:
>
>   - if:
>       properties:
>         compatible:
>           contains:
>             enum:
>               - img,img-bxs-4-64
>               - img,img-ge7800
>               - img,img-gx6250
>     then:
>       properties:
>         power-domains:
>           minItems: 2
>         power-domain-names:
>           minItems: 2
>
> Since mediatek,mt8173-mfgtop only provides a single power domain, wouldn't
> forcing minItems: 2 cause valid device trees to fail dt_binding_check? Should
> the conditional block be updated to exclude mediatek,mt8173-gpu?

Yeah, and we just assign the same power domain to both. The bot clearly
didn't look at the dts patch.


ChenYu

> >                - renesas,r8a7796-gpu
> >                - renesas,r8a77961-gpu
> >            - const: img,img-gx6250
>
> --
> Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3