Re: [PATCH 3/5] arm64: dts: qcom: Add Kalambo CRD

On 7/18/2026 5:46 PM, [email protected] wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] The device tree leaves orphaned nodes for the physically absent PMIC 'D', leading to invalid SPMI device probing and thermal zone registration.
> --
> 
> --- Patch [3]: [PATCH 3/5] arm64: dts: qcom: Add Kalambo CRD ---
> commit aaa6e566ef6b80e52c726e5cb734189e7e8ad2a3
> Author: Gopikrishna Garmidi <[email protected]>
> 
> arm64: dts: qcom: Add Kalambo CRD
> 
> Introduce support for the CRD based on the Qualcomm Kalambo SoC.
> It reuses the common CRD board description and drops the PMIC nodes
> not present on this design.
> 
>> diff --git a/arch/arm64/boot/dts/qcom/kalambo-crd.dts b/arch/arm64/boot/dts/qcom/kalambo-crd.dts
>> new file mode 100644
>> index 0000000000000..b4441807f4602
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/qcom/kalambo-crd.dts
>> @@ -0,0 +1,21 @@
>> +// SPDX-License-Identifier: BSD-3-Clause
>> +/*
>> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
>> + */
>> +
>> +/dts-v1/;
>> +
>> +#include "kalambo.dtsi"
>> +#include "glymur-crd.dtsi"
>> +
>> +/delete-node/ &pmcx0102_d_e0;
>> +/delete-node/ &pmcx0102_d0_thermal;
> 
> [Severity: Medium]
> Are the deletions for the SPMI bus 1 endpoint and its thermal zone missing
> here?
> 
> This drops the SPMI bus 0 endpoint for PMIC D, but seems to leave the bus 1
> endpoint (&pmcx0102_d_e1) and its thermal zone (&pmcx0102_d1_thermal) active.
> Since the PMIC is physically absent, attempting to probe the orphaned bus 1
> device and poll the absent thermal sensor can cause SPMI bus timeouts,
> deferred probes, and log spam from the thermal framework.
> 
> Should &pmcx0102_d_e1 and &pmcx0102_d1_thermal also be deleted in this block?
> 

No, these deletes are not missing.

Kalambo CRD keeps the PMIC D bus 1 endpoint. This was checked against
the schematics and also verified on the running target:

   # cat /sys/bus/spmi/devices/1-03/uevent
   DRIVER=pmic-spmi
   OF_NAME=pmic
   OF_FULLNAME=/soc@0/arbiter@c400000/spmi@c437000/pmic@3
   OF_COMPATIBLE_0=qcom,pmcx0102
   OF_COMPATIBLE_1=qcom,spmi-pmic

   # grep -H . /sys/class/thermal/thermal_zone*/type | grep 'pmcx0102-d1'
   /sys/class/thermal/thermal_zone74/type:pmcx0102-d1-thermal

So &pmcx0102_d_e1 and &pmcx0102_d1_thermal are valid on Kalambo CRD and
should remain enabled. Only &pmcx0102_d_e0 and &pmcx0102_d0_thermal are
deleted.

Thanks,
Gopikrishna