Re: [PATCH net-next v4 1/5] net: dsa: mv88e6xxx: only time stamp PTPv2 frames
Luke Howard <[email protected]>
| Newsgroups | dev.linux.lists.sashiko-reviews,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
> [Severity: High] > This isn't a bug introduced by this patch, but does ptp_parse_header() > guarantee that the returned header is in the linear region of the skb? This is a pre-existing bug shared by every caller of ptp_parse_header(). > [Severity: High] > This is another pre-existing issue, but does using the > MV88E6XXX_HWTSTAMP_ENABLED bit flag provide adequate synchronization? Worst case is a timestamp request being dropped mid-reconfiguration. I don’t think this is worth addressing. Luke