Re: Re: Re: [PATCH v13 5/5] clocksource: dw_apb_timer: Use reset array API to handle all resets
Philipp Zabel <[email protected]>
| Newsgroups | dev.linux.lists.sashiko-reviews,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pwm |
|---|---|
| Message-ID | <[email protected]> |
On Di, 2026-07-28 at 18:59 +0800, Xuyang Dong wrote:
[...]
> Will drop "reset_control_put(rstc);" and "rstc = NULL;".
> Keep only the content below:
>
> - rstc = of_reset_control_get(np, NULL);
> + rstc = of_reset_control_array_get_optional_exclusive(np);
> if (!IS_ERR(rstc)) {
> reset_control_assert(rstc);
> reset_control_deassert(rstc);
> }
>
> Do you think this change is correct?
If each timer has their own exclusive resets (or none at all), and they
have to be triggered at about the same time (if multiple), without any
ordering requirements, then yes, this looks correct.
regards
Philipp