Re: [PATCH v3 4/4] arm64: dts: qcom: hamoa-pmics: Add ADC support

On 7/27/2026 11:01 PM, [email protected] wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] The patch adds the `pmc8380_6_die_temp` ADC channel to `hamoa-pmics.dtsi`, but fails to delete it in several Purwa-based device trees that lack the PMC8380_6 PMIC.
> --
> 
> --- Patch [4]: [PATCH v3 4/4] arm64: dts: qcom: hamoa-pmics: Add ADC support ---
> commit 506a2efbee2639e175314a25d3b48970c6278e83
> Author: Ayyagari Ushasreevalli <[email protected]>
> 
> arm64: dts: qcom: hamoa-pmics: Add ADC support
> 
> Add ADC node and define channels for:
> - Die temperature for PMK8550, PM8550VE* and PMC8380* PMICs.
> - PM8550: Die temperature, VPH power, and system thermistors.
> 
> [ ... ]
> 
>> diff --git a/arch/arm64/boot/dts/qcom/purwa-iot-som.dtsi b/arch/arm64/boot/dts/qcom/purwa-iot-som.dtsi
>> index 394e65518ac50..661dca4fbee34 100644
>> --- a/arch/arm64/boot/dts/qcom/purwa-iot-som.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/purwa-iot-som.dtsi
>> @@ -10,6 +10,7 @@
>>  
>>  /delete-node/ &pmc8380_6;
>>  /delete-node/ &pmc8380_6_thermal;
>> +/delete-node/ &pmc8380_6_die_temp;
> 
> [Severity: Medium]
> Should &pmc8380_6_die_temp also be deleted for the other device trees that
> currently delete &pmc8380_6?
> 
> For example, these files also delete &pmc8380_6 and &pmc8380_6_thermal, but
> are missing the deletion for the newly added &pmc8380_6_die_temp channel:
> 
> - arch/arm64/boot/dts/qcom/x1p42100-asus-vivobook-s15.dts
> - arch/arm64/boot/dts/qcom/x1p42100-asus-zenbook-a14.dtsi
> - arch/arm64/boot/dts/qcom/x1p42100-crd.dts
> - arch/arm64/boot/dts/qcom/x1p42100-hp-omnibook-x14.dts
> - arch/arm64/boot/dts/qcom/x1p42100-lenovo-thinkbook-16.dts

Yes, that is true, the above files need the same modification. I'll
fix this in the next series.

Thanks,
Jishnu

> 
> Without deleting the die temp channel, the channel is registered with the ADC
> driver on these boards despite the PMC8380_6 PMIC not being present. Could
> this cause a timeout or bus error if userspace tries to read the dead IIO
> channel via sysfs?
>