Re: [PATCH v2 1/2] dt-bindings: phy: add binding for T-Head TH1520 USB PHY
Drew Fustini <[email protected]>
| Newsgroups | dev.linux.lists.sashiko-reviews,org.infradead.lists.linux-phy,org.kernel.vger.linux-devicetree |
|---|---|
| Message-ID | <amkaOo9mkjJfDNsf@x1> |
On Thu, Jul 23, 2026 at 10:09:48PM +0800, Icenowy Zheng wrote: > 在 2026-07-23四的 08:47 +0000,[email protected]写道: > > Thank you for your contribution! Sashiko AI review found 2 potential > > issue(s) to consider: > > - [Medium] The 'reg' property is omitted from the 'required' list for > > a memory-mapped PHY. > > - [Medium] The 'avdd33-usb3-supply' is omitted from the 'required' > > list based on software limitations rather than hardware description. > > BTW the power rail is expected to be always on at least according to > the schematics of multiple boards, as mentioned in the next patch. > > Thanks, > Icenowy That makes sense for the supply. However, I think the earlier point about 'reg' property is probably valid. Woudln't all users of this compatible need the base address? Thanks, Drew