Re: [PATCH v7 24/36] KVM: x86: Use ktime_get_snapshot_id() for master clock

On Tue, Jul 28, 2026, [email protected] wrote:
> Thank you for your contribution! Sashiko AI review found 6 potential issue(s) to consider:
> > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> > index 57494812cc839..45a768fd7cb35 100644
> > --- a/arch/x86/kvm/x86.c
> > +++ b/arch/x86/kvm/x86.c
> 
> [ ... ]
> 
> > @@ -1580,14 +1581,39 @@ static int do_realtime(struct timespec64 *ts, u64 *tsc_timestamp)
> 
> [Severity: Low]
> The commit message mentions replacing do_kvmclock_base, do_monotonic, 
> do_realtime, and vgettsc. Were these functions meant to be removed in this 
> patch? Leaving them defined as static helper functions without any callers 
> will break builds compiled with -Werror=unused-function.

Sashiko's "low" is my "high" :-)

arch/x86/kvm/x86.c:1575:12: error: ‘do_realtime’ defined but not used [-Werror=unused-function]
 1575 | static int do_realtime(struct timespec64 *ts, u64 *tsc_timestamp)
      |            ^~~~~~~~~~~
arch/x86/kvm/x86.c:1556:12: error: ‘do_monotonic’ defined but not used [-Werror=unused-function]
 1556 | static int do_monotonic(s64 *t, u64 *tsc_timestamp)
      |            ^~~~~~~~~~~~
arch/x86/kvm/x86.c:1533:12: error: ‘do_kvmclock_base’ defined but not used [-Werror=unused-function]
 1533 | static int do_kvmclock_base(s64 *t, u64 *tsc_timestamp)
      |            ^~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors