Re: [PATCH v2 1/2] dt-bindings: phy: add binding for T-Head TH1520 USB PHY

On Thu, Jul 23, 2026 at 10:05:24PM +0800, Icenowy Zheng wrote: > 在 2026-07-23四的 08:47 +0000，[email protected]写道：
> > Thank you for your contribution! Sashiko AI review found 2 potential
> > issue(s) to consider:
> > - [Medium] The 'reg' property is omitted from the 'required' list for
> > a memory-mapped PHY.
> > - [Medium] The 'avdd33-usb3-supply' is omitted from the 'required'
> > list based on software limitations rather than hardware description.
> 
> Well this is also to workaround the problem raised by Sashiko yourself
> at [1].
> 
> I didn't mention it in the log because I am not sure whether this is a
> real problem.
> 
> [1]
> https://sashiko.dev/#/patchset/20260507081710.4090814-1-zhengxingda%40iscas.ac.cn?part=6

I think Sashiko's comment on v1 was incorrect, and avdd33-usb3-supply
should be required.

Sashiko claimed that making avdd33-usb3-supply required would break
dtbs_check for boards that include th1520.dtsi but do not provide the
regulator. However, dtschema does not warn about missing properties if
the node is disabled [1]. Therefore, only boards that enable the usb phy
node would need to provide avdd33-usb3-supply.

Thanks,
Drew

[1] https://github.com/devicetree-org/dt-schema/blob/eb0e53d1c5b071865abbf7d251721431e8e6bd71/dtschema/dtb_validate.py#L256