Re: [PATCH v6 15/17] mtd: spinand: negotiate optimal controller operating point before dirmap creation

Hi Santhosh,

On 23/07/2026 at 12:02:23 GMT, [email protected] wrote:

> Thank you for your contribution! Sashiko AI review found 4 potential issue(s) to consider:
> - [High] Ranked controller optimization downgrades the read variant on tuning failure but fails to update or disable continuous read, leading to potential controller lockups and data corruption.
> - [High] The SPI NAND chip is unconditionally restored to ODTR mode upon system resume, even if controller optimization dynamically fell back to SSDR mode at probe time, breaking statically configured dirmaps.
> - [High] SPI controller PHY tuning state is lost across suspend/resume cycles.
> - [Medium] `spinand->max_write_op` is not reset between iterations in
> `spinand_try_ranked_variant()`, leaking `max_freq` modifications
> across tuning attempts.

The four reports seem legitimate. Some are easy to fix, the one about
continuous reads is a real concern I also had during my previous review
but forgot about it, and it is going to be slightly more challenging
than the others to handle properly. Of course we want both features to
work together, ideally.

Thanks,
Miquèl