Re: [PATCH] misc: pci_endpoint_test: Add WARN_ON() to detect broken EPC drivers
Niklas Cassel <[email protected]> Thu, 30 Jul 2026 14:02:11 +0200
| Newsgroups | dev.linux.lists.sashiko-reviews,org.kernel.vger.linux-pci |
|---|---|
| Message-ID | <ams9Q-34x6pjbARk@ryzen> |
On Wed, Jul 29, 2026 at 08:38:49PM +0000, [email protected] wrote: > Thank you for your contribution! Sashiko AI review found 4 potential issue(s) to consider: > > New issues: > - [High] The newly added `WARN_ON` can be trivially triggered by shared interrupts or untrusted hardware, leading to a Denial of Service (host panic) if `panic_on_warn` is enabled. Don't think this something we should care about. This is a test driver, and if someone plugs in a PCIe endpoint on the PCIe bus that runs the PCIe endpoint framework, and the pci-epf-test driver, they obviously know what they are doing, and want good/important warnings. > - [Medium] Direct, lockless read of the internal `done` field in `struct completion` causes a data race, violates API encapsulation, and relies on a flawed TOCTOU heuristic. Will user proper API in V2. Kind regards, Niklas