Re: [PATCH] misc: pci_endpoint_test: Add WARN_ON() to detect broken EPC drivers
Niklas Cassel <[email protected]> Thu, 30 Jul 2026 14:15:40 +0200
| Newsgroups | dev.linux.lists.sashiko-reviews,org.kernel.vger.linux-pci |
|---|---|
| Message-ID | <amtAbPGO5nYA1_VE@ryzen> |
On Thu, Jul 30, 2026 at 02:02:11PM +0200, Niklas Cassel wrote: > On Wed, Jul 29, 2026 at 08:38:49PM +0000, [email protected] wrote: > > - [Medium] Direct, lockless read of the internal `done` field in `struct completion` causes a data race, violates API encapsulation, and relies on a flawed TOCTOU heuristic. > > Will user proper API in V2. Seems like the proper API is to use completion_done(). But we cannot use this API, as it tries to take the completion spin lock... so it does not work. Will just drop this patch for now. Kind regards, Niklas