Re: [PATCH 2/2] arm64: dts: rockchip: support CAN1-CAN2-UART4 adapter for RK3588 Jaguar

On 7/30/26 3:35 PM, [email protected] wrote:
[...]
>> +
>> +/* RS232 */
>> +&uart4 {
>> +	/* ST3232B only guarantees 250Kbps */
>> +	max-speed = <250000>;
>> +	status = "okay";
>> +};
> 
> [Severity: Medium]
> Is the max-speed property effective when placed directly on the UART
> controller node?
> 
> According to the device tree bindings (serial-peripheral-props.yaml),
> max-speed is meant for serial peripherals (child nodes of the UART).
> Standard kernel UART drivers typically do not parse or enforce the
> max-speed property on the controller node itself.
> 
> Will this actually limit the baud rate, or will it be ignored by the driver?
> 
Forgot to check when porting from downstream. max-speed is seldom used 
in Linux kernel and it is indeed specific to devices on UART as does a 
quick "git grep max-speed drivers/" tell me. I'll send a v2 with that 
property removed but will leave a few days/weeks for comments, there's 
no hurry. Sorry for the noise.

Cheers,
Quentin