Re: [PATCH v8 08/18] media: iris: Add platform data field for watchdog interrupt mask
Dmitry Baryshkov <[email protected]> Fri, 31 Jul 2026 02:26:15 +0300
| Newsgroups | dev.linux.lists.sashiko-reviews,org.kernel.vger.linux-devicetree |
|---|---|
| Message-ID | <oqcjmsukorvnorsejp7s5njddzocksqh77j77ydv3p4t2emtyi@rerl6mx7kvcu> |
On Thu, Jul 30, 2026 at 03:32:30PM +0000, [email protected] wrote: > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: > - [Medium] Incomplete refactoring of watchdog interrupt bitmask. The new `wd_intr_mask` field is used for clearing and handling interrupts, but the hardware unmasking in `iris_vpu_interrupt_init()` still uses the hardcoded `WRAPPER_INTR_MASK_A2HWD_BMSK` (`BIT(3)`). This is expected and fine. AR50LT will override the interrupt_init callback. -- With best wishes Dmitry