Re: [PATCH v9 01/14] dt-bindings: media: qcom,glymur-iris: Add glymur video codec

On Wed, Jul 15, 2026 at 02:22:23PM +0000, [email protected] wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] Unnecessary `#address-cells` and `#size-cells` properties on a node without addressable children.
> --
> 
> --- Patch [1]: [PATCH v9 01/14] dt-bindings: media: qcom,glymur-iris: Add glymur video codec ---
> commit 8ca344fa9395fcf1d13bd1ea93de8bee21a5c176
> Author: Vishnu Reddy <[email protected]>
> 
> dt-bindings: media: qcom,glymur-iris: Add glymur video codec
> 
> This commit adds the device tree binding for the Qualcomm Glymur Iris video
> codec. It introduces a new dual-core architecture requiring additional
> power domains and clocks, and updates the maxItems limits in the common
> venus schema to accommodate these changes.
> 
> > diff --git a/Documentation/devicetree/bindings/media/qcom,glymur-iris.yaml b/Documentation/devicetree/bindings/media/qcom,glymur-iris.yaml
> > new file mode 100644
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/qcom,glymur-iris.yaml
> > @@ -0,0 +1,255 @@
> [ ... ]
> > +  interconnect-names:
> > +    items:
> > +      - const: cpu-cfg
> > +      - const: video-mem
> > +
> > +  '#address-cells':
> > +    const: 2
> > +
> > +  '#size-cells':
> > +    const: 2
> 
> [Severity: Low]
> Are these properties necessary here? The schema strictly enforces const: 2
> for #address-cells and #size-cells at the root node, but none of the child
> nodes (non-pixel, pixel, firmware) define a reg property, and the parent
> does not define a ranges property. 
> 
> Will this cause the DeviceTree compiler (dtc) to emit an 
> avoid_unnecessary_addr_size warning when compiling device trees using this
> node?

Indeed, it does (with W=1)

arch/arm64/boot/dts/qcom/glymur.dtsi:5365.29-5482.5: Warning
(avoid_unnecessary_addr_size): /soc@0/video-codec@aa00000: unnecessary
#address-cells/#size-cells without "ranges", "dma-ranges" or child "reg"
or "ranges" property


> 
> > +
> > +  non-pixel:
> > +    type: object
> [ ... ]
> > +        resets = <&gcc_video_axi0c_clk_ares>,
> > +                 <&gcc_video_axi0_clk_ares>,
> > +                 <&videocc_mvs0c_freerun_clk_ares>,
> > +                 <&videocc_mvs0_freerun_clk_ares>,
> > +                 <&gcc_video_axi1_clk_ares>,
> > +                 <&videocc_mvs1_freerun_clk_ares>;
> > +        reset-names = "core_bus",
> > +                      "vcodec0_bus",
> > +                      "core",
> > +                      "vcodec0_core",
> > +                      "vcodec1_bus",
> > +                      "vcodec1_core";
> > +
> > +        #address-cells = <2>;
> > +        #size-cells = <2>;
> 
> [Severity: Low]
> Does the example need #address-cells and #size-cells? It demonstrates their
> use without any child nodes containing reg properties, which directly causes a
> dtc warning during dt_binding_check validation.
> 
> > +
> > +        non-pixel {
> > +            iommus = <&apps_smmu 0x1940 0x0000>,
> > +                     <&apps_smmu 0x1944 0x0000>,
> > +                     <&apps_smmu 0x19e0 0x0000>;
> 
> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1

-- 
With best wishes
Dmitry