Re: [PATCH v4 47/48] KVM: selftests: Add VGICv5 LPI delivery tests

On Fri, 2026-07-24 at 12:18 +0000, [email protected] wrote:
> > +	/* VPE0 programs a linear LPI IST from the virtual IRS ID
> > registers. */
> > +	ret = run_vcpu(vcpus[0]);
> > +	TEST_ASSERT(!ret, "Failed to run GICv5 LPI vCPU0");
> > +	TEST_ASSERT(get_ucall(vcpus[0], &uc) == UCALL_SYNC &&
> > +		    uc.args[1] == GUEST_CMD_IS_READY,
> > +		    "GICv5 LPI vCPU0 did not become ready");
> > +
> > +	/* VPE1 observes the IST and enables the LPIs it will
> > receive/send. */
> > +	ret = run_vcpu(vcpus[1]);
> 
> [Severity: Low]
> This comment indicates that VPE1 will enable the LPIs it receives and
> sends.
> However, looking at guest_lpi_code(), the LPI configuration via
> gicv5_configure_test_lpis() is restricted strictly to VPE0:
> 
> 	if (!vcpu_id) {
> 		gicv5_enable_irs();
> 		gicv5_configure_lpi_ist();
> 		gicv5_configure_test_lpis();
> 		WRITE_ONCE(lpi_ist_ready, true);
> 	}
> 
> Could this comment in test_vgic_v5_lpis() be updated to accurately
> reflect
> that only VPE0 performs the LPI configuration step?

Have updated the out of date comment.

Thanks,
Sascha