Re: [PATCH v6 3/5] dt-bindings: mfd: x-powers,axp152: Document AXP318W

On ven. 31 juil. 2026 at 14:53, [email protected] wrote:

> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] The compatible string `x-powers,axp318w` is omitted from the
> conditional block that makes the `interrupts` property optional.
> --
>
> --- Patch [3]: [PATCH v6 3/5] dt-bindings: mfd: x-powers,axp152: Document AXP318W ---
> commit 0a2fd6c8b0d8fd1a45bf4a464bf3e71df8fa62f6
> Author: Andre Przywara <[email protected]>
>
> dt-bindings: mfd: x-powers,axp152: Document AXP318W
>
> This commit documents the AXP318W PMIC in the x-powers,axp152 bindings.
> It adds the new compatible string to the lists of PMICs that lack PWM
> frequency properties, and adds new input supply properties.
>
>> diff --git a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml
>> b/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml
>> index 45f015d63df16..38556c32417b3 100644
>> --- a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml
>> +++ b/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml
>> @@ -83,6 +83,7 @@ allOf:
>
> [Severity: Medium]
> Was the x-powers,axp318w compatible string intentionally omitted from the
> interrupt requirement conditional block earlier in this file?
>
> Looking at the block just above this hunk:
>
>   - if:
>       not:
>         properties:
>           compatible:
>             contains:
>               enum:
>                 - x-powers,axp15060
>                 - x-powers,axp305
>                 - x-powers,axp313a
>                 - x-powers,axp323
>     then:
>       required:
>         - interrupts
>
> Since x-powers,axp318w is missing from this exclusion list, the interrupts
> property will be strictly enforced during schema validation. Does
> this match the expected configuration for this PMIC?

In the case of the cubie a7a it is wired to the NMI controller but NO,
it is not strictly required. A platform may not wire the IRQ and it
would be fine

>
>>            contains:
>>              enum:
>>                - x-powers,axp313a
>> +              - x-powers,axp318w
>>                - x-powers,axp323
>>                - x-powers,axp15060
>>                - x-powers,axp717

-- 
Jerome