Re: [PATCH 2/4] dt-bindings: sound: fsl,easrc: add ports binding for multiple contexts

On Mon, Jul 20, 2026 at 10:16:52AM +0000, [email protected] wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] The schema fails to restrict the `ports` container to the 4 supported contexts (ports 0-3), allowing invalid extraneous ports to silently pass validation.
> --
> 
> --- Patch [2]: [PATCH 2/4] dt-bindings: sound: fsl,easrc: add ports binding for multiple contexts ---
> commit 0461b121d300fd40233634f4b977c32906d647ce
> Author: Shengjiu Wang <[email protected]>
> 
> dt-bindings: sound: fsl,easrc: add ports binding for multiple contexts
> 
> The i.MX EASRC hardware supports up to four conversion contexts
> (A, B, C, D). Add a ports container property to the binding to allow
> each context to be represented as an individual audio-graph port.
> 
> > diff --git a/Documentation/devicetree/bindings/sound/fsl,easrc.yaml b/Documentation/devicetree/bindings/sound/fsl,easrc.yaml
> > index d5727f8bfb0b5..0f579870110d9 100644
> > --- a/Documentation/devicetree/bindings/sound/fsl,easrc.yaml
> > +++ b/Documentation/devicetree/bindings/sound/fsl,easrc.yaml
> > @@ -55,6 +55,29 @@ properties:
> >        - const: imx/easrc/easrc-imx8mn.bin
> >      description: The coefficient table for the filters
> >  
> > +  ports:
> > +    $ref: /schemas/graph.yaml#/properties/ports
> > +    properties:
> > +      port@0:
> > +        $ref: audio-graph-port.yaml#
> > +        unevaluatedProperties: false
> > +        description: port for context A
> 
> [Severity: Low]
> Is this ports container missing a constraint to reject unsupported unit
> addresses?
> 
> Since the inherited graph.yaml schema permits any port@.*, a device tree
> defining port@4 or higher will currently pass dt-validate without an error,
> even though the hardware only supports 4 contexts. 
> 
> Would adding patternProperties: "^port@[0-3]$" or unevaluatedProperties: false
> to the ports block help catch invalid device tree configurations?

'additionalProperties: false' in 'ports' is what is needed here.

Rob