Re:Re: [PATCH] hwmon: (nzxt-smart2) Check return value of init_device() in probe

"Qingshuang Fu" <[email protected]> Tue, 4 Aug 2026 16:21:25 +0800 (CST)
Newsgroups dev.linux.lists.sashiko-reviews,org.kernel.vger.linux-hwmon
Message-ID <[email protected]>
CkF0IDIwMjYtMDgtMDQgMTY6MDA6MDEsIHNhc2hpa28tYm90QGtlcm5lbC5vcmcgd3JvdGU6Cj5U
aGFuayB5b3UgZm9yIHlvdXIgY29udHJpYnV0aW9uISBTYXNoaWtvIEFJIHJldmlldyBmb3VuZCAx
IHBvdGVudGlhbCBpc3N1ZShzKSB0byBjb25zaWRlcjoKPgo+UHJlLWV4aXN0aW5nIGlzc3VlczoK
Pi0gW0hpZ2hdIFN5c2ZzIHJlYWQgYW5kIHdyaXRlIGhhbmRsZXJzIHdhaXQgaW5kZWZpbml0ZWx5
IGZvciBoYXJkd2FyZSByZXBvcnRzIHdpdGhvdXQgcHJvdmlkaW5nIGEgbWVjaGFuaXNtIHRvIGJy
ZWFrIHRoZSB3YWl0IG9uIGRldmljZSBkaXNjb25uZWN0LCBjYXVzaW5nIHRoZSBkZXZpY2UgdW5i
aW5kIHRocmVhZCB0byBkZWFkbG9jay4KPi0tCj4KPi0tLSBQYXRjaCBbMV06IFtQQVRDSF0gaHdt
b246IChuenh0LXNtYXJ0MikgQ2hlY2sgcmV0dXJuIHZhbHVlIG9mIGluaXRfZGV2aWNlKCkgaW4g
cHJvYmUgLS0tCj5jb21taXQgMTg0MzUwNTBiYjA0MDhiZTBhYTFlNTcwYzdhMjk3NmE0NjhkNTJj
MAo+QXV0aG9yOiBRaW5nc2h1YW5nIEZ1IDxmdXFpbmdzaHVhbmdAa3lsaW5vcy5jbj4KPgo+aHdt
b246IChuenh0LXNtYXJ0MikgQ2hlY2sgcmV0dXJuIHZhbHVlIG9mIGluaXRfZGV2aWNlKCkgaW4g
cHJvYmUKPgo+VGhpcyBjb21taXQgdXBkYXRlcyB0aGUgbnp4dC1zbWFydDIgZHJpdmVyIHRvIGNo
ZWNrIHRoZSByZXR1cm4gdmFsdWUgb2YKPmluaXRfZGV2aWNlKCkgZHVyaW5nIHByb2JlLiBJZiB0
aGUgaGFyZHdhcmUgaXMgdW5yZXNwb25zaXZlIGFuZCBpbml0aWFsaXphdGlvbgo+ZmFpbHMsIHRo
ZSBkcml2ZXIgbm93IGNvcnJlY3RseSBhYm9ydHMgcmF0aGVyIHRoYW4gcmVnaXN0ZXJpbmcgdGhl
IGh3bW9uCj5kZXZpY2UgaW4gYW4gaW5jb25zaXN0ZW50IHN0YXRlLiBUaGlzIHNhZmVseSB1dGls
aXplcyBhbiBlYXJsaWVyIGZpeCB0aGF0Cj5zdG9wcyBkZXZpY2UgSU8gYmVmb3JlIGNsb3Npbmcg
dGhlIGhhcmR3YXJlLgo+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2h3bW9uL256eHQtc21hcnQy
LmMgYi9kcml2ZXJzL2h3bW9uL256eHQtc21hcnQyLmMKPj4gaW5kZXggZmYwYzBiZWUwZTgzOS4u
ZWZjNzhhOGY1OGM4OCAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9od21vbi9uenh0LXNtYXJ0Mi5j
Cj4+ICsrKyBiL2RyaXZlcnMvaHdtb24vbnp4dC1zbWFydDIuYwo+PiBAQCAtNzU0LDcgKzc1NCwx
MSBAQCBzdGF0aWMgaW50IG56eHRfc21hcnQyX2hpZF9wcm9iZShzdHJ1Y3QgaGlkX2RldmljZSAq
aGRldiwKPj4gIAo+PiAgCWhpZF9kZXZpY2VfaW9fc3RhcnQoaGRldik7Cj4+ICAKPj4gLQlpbml0
X2RldmljZShkcnZkYXRhLCBVUERBVEVfSU5URVJWQUxfREVGQVVMVF9NUyk7Cj4+ICsJcmV0ID0g
aW5pdF9kZXZpY2UoZHJ2ZGF0YSwgVVBEQVRFX0lOVEVSVkFMX0RFRkFVTFRfTVMpOwo+PiArCWlm
IChyZXQpIHsKPj4gKwkJZGV2X2VycigmaGRldi0+ZGV2LCAiaW5pdF9kZXZpY2UgZmFpbGVkOiAl
ZFxuIiwgcmV0KTsKPj4gKwkJZ290byBvdXRfaHdfY2xvc2U7Cj4+ICsJfQo+PiAgCj4+ICAJZHJ2
ZGF0YS0+aHdtb24gPQo+PiAgCQlod21vbl9kZXZpY2VfcmVnaXN0ZXJfd2l0aF9pbmZvKCZoZGV2
LT5kZXYsICJuenh0c21hcnQyIiwgZHJ2ZGF0YSwKPgo+W1NldmVyaXR5OiBIaWdoXQo+VGhpcyBp
cyBhIHByZS1leGlzdGluZyBpc3N1ZSwgYnV0IGRvZXMgdGhlIGRyaXZlciBoYW5kbGUgZGV2aWNl
IGRpc2Nvbm5lY3RzCj5zYWZlbHkgd2hpbGUgYmxvY2tlZCBpbiBzeXNmcyByZWFkcz8KPgo+SWYg
YSB1c2Vyc3BhY2UgcHJvZ3JhbSBpcyByZWFkaW5nIGEgc3lzZnMgYXR0cmlidXRlIChsaWtlIHB3
bTFfZW5hYmxlKSBhbmQKPmJsb2NrcyBpbiBuenh0X3NtYXJ0Ml9od21vbl9yZWFkKCkgYmVjYXVz
ZSB0aGUgZGV2aWNlIGhhc24ndCBzZW50IHRoZQo+cmVxdWlyZWQgcmVwb3J0Ogo+Cj5kcml2ZXJz
L2h3bW9uL256eHQtc21hcnQyLmM6bnp4dF9zbWFydDJfaHdtb25fcmVhZCgpIHsKPiAgICAuLi4K
PiAgICByZXMgPSB3YWl0X2V2ZW50X2ludGVycnVwdGlibGVfbG9ja2VkX2lycShkcnZkYXRhLT53
cSwKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkcnZkYXRh
LT5mYW5fY29uZmlnX3JlY2VpdmVkKTsKPiAgICAuLi4KPn0KPgo+SWYgdGhlIGRldmljZSBpcyBz
dWRkZW5seSBkaXNjb25uZWN0ZWQsIG56eHRfc21hcnQyX2hpZF9yZW1vdmUoKSBjYWxscwo+aHdt
b25fZGV2aWNlX3VucmVnaXN0ZXIoKSB3aXRob3V0IHdha2luZyB1cCB0aGUgd2FpdCBxdWV1ZSBv
ciBzaWduYWxpbmcgYQo+ZGlzY29ubmVjdC4gV2lsbCB0aGlzIGNhdXNlIGEgZGVhZGxvY2sgaW4g
a2VybmZzX2RyYWluIHNpbmNlIHRoZSBzeXNmcwo+dGhyZWFkIG5ldmVyIHdha2VzIHVwIHRvIGZp
bmlzaCBpdHMgcmVhZD8KPgo+LS0gCj5TYXNoaWtvIEFJIHJldmlldyChpCBodHRwczovL3Nhc2hp
a28uZGV2LyMvcGF0Y2hzZXQvMjAyNjA4MDQwNzQ4NDIuNTA1OTIzLTEtZmZmc3FpYW5AMTYzLmNv
bT9wYXJ0PTEKClRoYW5rcyBmb3IgdGhlIGF1dG9tYXRlZCByZXZpZXcuCgpUaGUgZGVhZGxvY2sg
c2NlbmFyaW8geW91IG5vdGVkIGlzIGEgcHJlLWV4aXN0aW5nIGlzc3VlIHdpdGhpbiB0aGUgZHJp
dmVyIGFuZCBmYWxscyBvdXRzaWRlIHRoZSBzY29wZSBvZiB0aGlzIHBhdGNoLgpUaGlzIGNoYW5n
ZSBhZGRyZXNzZXMgZmFpbHVyZXMgb2NjdXJyaW5nIGR1cmluZyBlYXJseSBwcm9iZS4gSWYgaW5p
dF9kZXZpY2UoKSByZXR1cm5zIGFuIGVycm9yLCB0aGUgcHJvYmUgYWJvcnRzIGJlZm9yZSBod21v
bl9kZXZpY2VfcmVnaXN0ZXJfd2l0aF9pbmZvKCkgaXMgY2FsbGVkLiBTaW5jZSBubyBzeXNmcyBh
dHRyaWJ1dGVzIGFyZSBjcmVhdGVkIGluIHRoaXMgZXJyb3IgcGF0aCwgdGhlcmUgaXMgbm8gb3Bw
b3J0dW5pdHkgZm9yIHVzZXJzcGFjZSByZWFkZXJzIHRvIGJsb2NrIG9uIHdhaXRfZXZlbnQuCgpJ
IHdvdWxkIGxpa2UgdG8ga2VlcCB0aGlzIHBhdGNoIG5hcnJvd2x5IGZvY3VzZWQgb24gcHJldmVu
dGluZyByZWdpc3RyYXRpb24gb2YgYW4gaW5jb21wbGV0ZWx5IGluaXRpYWxpemVkIGh3bW9uIGRl
dmljZSwgYW5kIG5vdCBleHBhbmQgaXQgdG8gY292ZXIgb3RoZXIgdW5yZWxhdGVkIGV4aXN0aW5n
IHByb2JsZW1zLgoKUWluZ3NodWFuZyBGdQo=